This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Publish explicit dependency version requirements #684
Comments
johanbrandhorst
changed the title
johanbrandhorst
added a commit
to johanbrandhorst/opencensus-go
that referenced
this issue
Apr 13, 2018
Adds Gopkg.toml and Gopkg.lock with initial dependency versions. Includes workaround for Apache Thrift repo migration. Fixes census-instrumentation#684.
johanbrandhorst
added a commit
to johanbrandhorst/opencensus-go
that referenced
this issue
Apr 16, 2018
Adds Gopkg.toml and Gopkg.lock with initial dependency versions. Includes workaround for Apache Thrift repo migration. Ignores the vendor folder and adds a travis test to ensure dependency version updates don't break the build. Fixes census-instrumentation#684.
johanbrandhorst
added a commit
to johanbrandhorst/opencensus-go
that referenced
this issue
Apr 16, 2018
Adds Gopkg.toml and Gopkg.lock with initial dependency versions. Includes workaround for Apache Thrift repo migration. Ignores the vendor folder and adds a travis test to ensure dependency version updates don't break the build. Fixes census-instrumentation#684.
johanbrandhorst
added a commit
to johanbrandhorst/opencensus-go
that referenced
this issue
Apr 16, 2018
Adds Gopkg.toml and Gopkg.lock with initial dependency versions. Includes workaround for Apache Thrift repo migration. Ignores the vendor folder and adds a travis test to ensure dependency version updates don't break the build. Fixes census-instrumentation#684.
johanbrandhorst
added a commit
to johanbrandhorst/opencensus-go
that referenced
this issue
Apr 16, 2018
Adds Gopkg.toml and Gopkg.lock with initial dependency versions. Includes workaround for Apache Thrift repo migration. Ignores the vendor folder and adds a travis test to ensure dependency version updates don't break the build. Fixes census-instrumentation#684.
rakyll
pushed a commit
that referenced
this issue
Apr 16, 2018
Adds Gopkg.toml and Gopkg.lock with initial dependency versions. Includes workaround for Apache Thrift repo migration. Ignores the vendor folder and adds a travis test to ensure dependency version updates don't break the build. Fixes #684.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Using OpenCensus for Go with gRPC depends on recent versions of gRPC-Go. However, this dependency is never made explicit anywhere (such as a
Gopkg.tomlorgo.modfile). I understand this is a bit in flux at the moment with the vgo proposal, but I think we should discuss how we make these version dependencies explicit, so I'm opening this issue for the purposes of that discussion.Personally, I would welcome simply defining a
Gopkg.tomland generate aGopkg.lockand check those in right now. It would help users ofgolang/depto get started with OpenCensus, and we could also include a fix for #675 in the dependency declaration.Later on, as vgo is merged into the standard tool, we can move to defining a
go.modfile.The text was updated successfully, but these errors were encountered: