Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to trailing comma style in spec.js and gulpfile.js #19

Closed
dpilafian opened this issue Dec 16, 2019 · 0 comments
Closed

Switch to trailing comma style in spec.js and gulpfile.js #19

dpilafian opened this issue Dec 16, 2019 · 0 comments

Comments

@dpilafian
Copy link
Member

dpilafian commented Dec 16, 2019

For multiline arrays and objects, the consistency of including a comma for the last item makes the code easier to edit and helps reduce merge diffs.

See:
https://jshint.com/docs/options/#trailingcomma

For example, change:

const dataSet = [
   { input: '002', expected: 'BANAMEX' },
   { input: '640', expected: 'CB JPMORGAN' },
   { input: '652', expected: 'CREDICAPITAL' }  //no comma
   ];

to:

const dataSet = [
   { input: '002', expected: 'BANAMEX' },
   { input: '640', expected: 'CB JPMORGAN' },
   { input: '652', expected: 'CREDICAPITAL' },  //with comma
   ];
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant