Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Allow NULL" toggle option to column header menu #771

Closed
Tracked by #499
seancolsen opened this issue Oct 28, 2021 · 0 comments · Fixed by #792
Closed
Tracked by #499

Add "Allow NULL" toggle option to column header menu #771

seancolsen opened this issue Oct 28, 2021 · 0 comments · Fixed by #792
Assignees
@seancolsen
Labels
type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Milestone
[06] Working with...

Comments

@seancolsen
Copy link
Contributor

seancolsen commented Oct 28, 2021 •
edited
Loading

Additional details:

  • See What's the best terminology to use in our UI for the concept of NULL? #778 for a discussion about what to call the NULL value
  • Column header menu should display the "Allow Empty" state for every column
  • Column header menu should let the user alter the "Allow Empty" state for columns that don't have a constraint of type 'primary'.
  • Loading spinner should display within menu while making request
  • Code comment should provide a placeholder for using the toast system (yet to be built) for displaying error if the request to alter the constraint failed.
@seancolsen seancolsen added type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory status: triage labels Oct 28, 2021
This was referenced Oct 28, 2021
Closed
Closed
@pavish pavish added ready Ready for implementation and removed status: triage labels Oct 29, 2021
@pavish pavish moved this from Triage to Ready in [NO LONGER USED] Mathesar work tracker Oct 29, 2021
@pavish pavish added this to the [07] Working with Tables milestone Oct 29, 2021
@pavish pavish mentioned this issue Oct 29, 2021
Closed
@seancolsen seancolsen self-assigned this Oct 29, 2021
@seancolsen seancolsen added status: started and removed ready Ready for implementation labels Oct 29, 2021
@seancolsen seancolsen changed the title Add "Allow Empty" toggle option to column header menu Add "Allow NULL" toggle option to column header menu Nov 1, 2021
@seancolsen seancolsen mentioned this issue Nov 2, 2021
Merged
7 tasks
Repository owner moved this from Started to Done in [NO LONGER USED] Mathesar work tracker Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seancolsen seancolsen

Labels
type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
[NO LONGER USED] Mathesar work tracker
Archived in project
Milestone
[06] Working with Tables
Development

Successfully merging a pull request may close this issue.

Add "Allow NULL" toggle option to column header menu mathesar-foundation/mathesar
2 participants
@seancolsen @pavish