Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashboards): implements endpoint to delete a playlist #2721

Merged
merged 19 commits into from
Nov 30, 2023
Merged

feat(dashboards): implements endpoint to delete a playlist #2721

merged 19 commits into from
Nov 30, 2023

Conversation

jeremyjaouen
Copy link
Contributor

@jeremyjaouen jeremyjaouen commented Nov 28, 2023 •
edited
Loading

Description

This PR intends to implements endpoint to delete a playlist

Playlist deletion works as follow:

  • An admin can remove any playlist
  • A non admin can only remove playlist share with him as editor
  • While deleting a playlist all the shares between playlist <=> contacts / contactgroups / dashboards are remove.

API Examples:

Delete a playlist successful
image

Delete a playlist as non-admin with no rights with playlist
image

Delete a nonexistent playlist
image

PHPStan Level 9

image

Fixes # MON-25072

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

  • 22.04.x
  • 22.10.x
  • 23.04.x
  • 23.10.x
  • 24.04.x (master)

Checklist

Community contributors & Centreon team

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (master, maintenance).

Base automatically changed from MON-24896 to develop November 29, 2023 08:31
@jeremyjaouen jeremyjaouen marked this pull request as ready for review November 30, 2023 07:54
@jeremyjaouen jeremyjaouen requested a review from a team as a code owner November 30, 2023 07:54
@jeremyjaouen jeremyjaouen changed the title [WIP] feat(dashboards): implements endpoint to delete a playlist feat(dashboards): implements endpoint to delete a playlist Nov 30, 2023
arnapou
arnapou previously approved these changes Nov 30, 2023
View reviewed changes
@jeremyjaouen @arnapou
Update centreon/src/Core/Dashboard/Playlist/Infrastructure/API/Delete…
88ae7c3 
…Playlist/DeletePlaylistController.php

Co-authored-by: Arnaud Buathier <abuathier@centreon.com>
arnapou
arnapou previously approved these changes Nov 30, 2023
View reviewed changes
@jeremyjaouen jeremyjaouen requested a review from a team as a code owner November 30, 2023 09:32
@jeremyjaouen jeremyjaouen merged commit 2f76669 into develop Nov 30, 2023
212 checks passed
@jeremyjaouen jeremyjaouen deleted the MON-25072 branch November 30, 2023 10:17
jeremyjaouen added a commit that referenced this pull request Dec 1, 2023
@jeremyjaouen
feat(dashboards): implements endpoint to delete a playlist (#2721)
0741e73
@jeremyjaouen jeremyjaouen mentioned this pull request Dec 1, 2023
Merged
12 tasks
jeremyjaouen added a commit that referenced this pull request Dec 1, 2023
@jeremyjaouen
feat(dashboards): implements endpoint to delete a playlist (#2721) (#…
d45532f 
…2776)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnapou arnapou arnapou approved these changes

@adr-mo adr-mo adr-mo approved these changes

@smau-centreon smau-centreon smau-centreon approved these changes

@dmyios dmyios Awaiting requested review from dmyios dmyios is a code owner automatically assigned from centreon/owners-php

Assignees
No one assigned
Labels
area/backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeremyjaouen @arnapou @adr-mo @smau-centreon