enh(service_groups): add search capabilities to host categories endpoint #4181
Conversation
WalkthroughThe recent changes to the Changes
Poem
Tip Early Access Features
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
centreon/src/Centreon/Infrastructure/Monitoring/MonitoringRepositoryRDB.php
Show resolved
Hide resolved
centreon/src/Centreon/Infrastructure/Monitoring/MonitoringRepositoryRDB.php
Outdated
Show resolved
Hide resolved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
centreon/doc/API/centreon-api.yamlis excluded by!**/*.yaml
Files selected for processing (1)
- centreon/src/Centreon/Infrastructure/Monitoring/MonitoringRepositoryRDB.php (3 hunks)
Additional comments not posted (1)
centreon/src/Centreon/Infrastructure/Monitoring/MonitoringRepositoryRDB.php (1)
1582-1585: Verify the conditions for joining services.The conditions for joining services include checks for
srv.enabledandsrv.service_register. It's important to verify that these conditions correctly reflect the intended business logic, especially the use ofsrv.service_register.Verification successful
The conditions for joining services in the
MonitoringRepositoryRDB.phpfile include checks forsrv.enabledandsrv.service_register. These conditions appear multiple times and seem consistent with the intended business logic.
srv.enabled = '1'srv.service_register = '1'These conditions are used to ensure that only enabled and registered services are included in the joins.
- centreon/src/Centreon/Infrastructure/Monitoring/MonitoringRepositoryRDB.php:
ON srv.service_id = ssg.service_id AND srv.host_id = h.host_id AND srv.enabled = '1' AND srv.service_register = '1'Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the conditions under which services are joined to ensure they are correct. # Test: Search for the conditions used in service joins. Expect: Conditions align with business logic. rg --type sql $'srv.service_register = 1'Length of output: 42
Script:
#!/bin/bash # Description: Verify the conditions under which services are joined to ensure they are correct. # Test: Search for the broader context of service joins in SQL files. rg --type sql 'JOIN srv' # Test: Search for conditions used in service joins. rg --type sql 'ON srv'Length of output: 51
Script:
#!/bin/bash # Description: Verify the conditions under which services are joined to ensure they are correct. # Test: Search for any join conditions in SQL files. rg --type sql 'JOIN' # Test: Search for service-related conditions in SQL files. rg --type sql 'service'Length of output: 58956
Script:
#!/bin/bash # Description: Verify the conditions under which services are joined in the MonitoringRepositoryRDB.php file. # Test: Search for SQL join conditions involving services in the MonitoringRepositoryRDB.php file. rg 'JOIN.*srv' centreon/src/Centreon/Infrastructure/Monitoring/MonitoringRepositoryRDB.php # Test: Search for service-related conditions in the MonitoringRepositoryRDB.php file. rg 'srv\.' centreon/src/Centreon/Infrastructure/Monitoring/MonitoringRepositoryRDB.phpLength of output: 11318
centreon/src/Centreon/Infrastructure/Monitoring/MonitoringRepositoryRDB.php
Show resolved
Hide resolved
centreon/src/Centreon/Infrastructure/Monitoring/MonitoringRepositoryRDB.php
Outdated
Show resolved
Hide resolved
centreon/src/Centreon/Infrastructure/Monitoring/MonitoringRepositoryRDB.php
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
centreon/doc/API/centreon-api.yamlis excluded by!**/*.yaml
Files selected for processing (1)
- centreon/src/Centreon/Infrastructure/Monitoring/MonitoringRepositoryRDB.php (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- centreon/src/Centreon/Infrastructure/Monitoring/MonitoringRepositoryRDB.php
|
details
|
This PR intends to add a host_group search capability to the realtime servicegroups endpoint.
Fixes # (issue)
Type of change
Target serie
How this pull request can be tested ?
Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.
Any relevant details of the configuration to perform the test should be added.
Checklist
Community contributors & Centreon team