library/rados_user.py modify #7296
Comments
|
display_name is a mandatory parameter to radosgw-admin command. If you do not set the display_name, it fails creating the user with Seems to be an easy fix, I will take a look at it. Thx |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions. |
|
Ill create a PR for this |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions. |
|
@karasjoh000 what is the status on this? should we take over? |
|
This should be a 2 line fix I think. |
Removes the case when display_name was defined prevously but was not provided when modifying. Without this change the module will change display_name to name even if display_name was not name originally. See ceph#7296 Signed-off-by: John Karasev <john.karasev@intel.com>
Removes the case when display_name was defined prevously but was not provided when modifying. Without this change the module will change display_name to name even if display_name was not name originally. See #7296 Signed-off-by: John Karasev <john.karasev@intel.com>
Removes the case when display_name was defined prevously but was not provided when modifying. Without this change the module will change display_name to name even if display_name was not name originally. See #7296 Signed-off-by: John Karasev <john.karasev@intel.com> (cherry picked from commit 72ff93f)
Removes the case when display_name was defined prevously but was not provided when modifying. Without this change the module will change display_name to name even if display_name was not name originally. See #7296 Signed-off-by: John Karasev <john.karasev@intel.com> (cherry picked from commit 72ff93f)
Removes the case when display_name was defined prevously but was not provided when modifying. Without this change the module will change display_name to name even if display_name was not name originally. See #7296 Signed-off-by: John Karasev <john.karasev@intel.com> (cherry picked from commit 72ff93f)
Removes the case when display_name was defined prevously but was not provided when modifying. Without this change the module will change display_name to name even if display_name was not name originally. See #7296 Signed-off-by: John Karasev <john.karasev@intel.com> (cherry picked from commit 72ff93f)
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation. |
ceph-ansible/library/radosgw_user.py
Lines 268 to 269 in b40e4bf
If display_name != name and display_name is not provided as a param, then display_name is changed to name although the expectation will be that display_name should not change.
Note: I did not test this, but it seems that L268 and L269 need to be removed.
The text was updated successfully, but these errors were encountered: