profiles: introducing cluster profiles

[leseb]

This commit introduces a new directory called "profiles" which
contains some set of variables for a particular use case. These profiles
provide guidance for certain scenarios such as:

• configuring rgw with keystone v3

Signed-off-by: Sébastien Han seb@redhat.com

[dang]

Looks good to me.

[leseb]

@cloudnull any idea why I'm getting the rgw section twice?

[client.rgw.ceph-rgw0]
keyring = /var/lib/ceph/radosgw/ceph-rgw.ceph-rgw0/keyring
rgw data = /var/lib/ceph/radosgw/ceph-rgw.ceph-rgw0
host = ceph-rgw0
rgw socket path = /tmp/radosgw-ceph-rgw0.sock
log file = /var/log/ceph/ceph-rgw-ceph-rgw0.log
rgw frontends = civetweb port=10.0.2.15:8080 num_threads=50

[client.rgw.ceph-rgw0]
rgw keystone token cache size = 10000
rgw keystone url = http://192.168.0.1:35357
rgw s3 auth use keystone = true
nss db path = /var/lib/ceph/radosgw/ceph-radosgw.ceph-rgw0/nss
rgw keystone accepted roles = Member, _member_, admin
rgw keystone admin token = password
rgw keystone revocation interval = 900

Could this be because of the {{ hostvars[inventory_hostname]['ansible_hostname'] }}?
Thanks!

[cloudnull]

Are these overrides combined and targetting the same file via some kind of a hash merge happening elsewhere? It looks like the overrides contain different values between the sections which would be something triggered by loading the two sections keys into the same override dictionary.

[leseb]

@cloudnull well I have my ceph.conf.j2 template that fills the default content of the section and then I filled group_vars/rgws with overrrides. This is the only thing that is happening here.

Am I missing something?

[OrFriedmann]

@leseb @cloudnull The problem is in the config_template module (v2 and v1) as in line 303 of v2 of the module, it is not recongnize the section of the rgw and it creates the new section.

I put q in the module :
0.8s return_config_overrides_ini: config.sections()=["client.rgw.{{ hostvars[inventory_hostname]['ansible_hostname'] }}", 'global', 'client.libvirt', 'client.rgw.ceph-osd0', 'osd']

[leseb]

Thanks @OrFriedmann for looking into this, do you guys think we can get an easy fix for this? @cloudnull

Thanks!

[OrFriedmann]

I have an idea how to solve this, Please comment if you are agree with me
We can create all.j2 or rgw.j2 and use jinja to create the sections with the names of the rgws and voilà.

[leseb]

@OrFriedmann do you mind giving this a try and tell us if that works?
I'd love to merge this at some point :)
Thanks!

[cloudnull]

@leseb @OrFriedmann are we still seeing this with the updated module for 2.2 ?

[cloudnull]

also, does the section "[client.rgw.ceph-rgw0]" already exist in the target file which config_template is attempting to append to?

[leseb]

@cloudnull the issue is still present with ansible 2.2. The section doesn't exist before it gets created. Running ansible twice doesn't merge both sections.

[OrFriedmann]

@leseb @cloudnull The problem as I see it is that the add_section function in the config_template module compares the name of the variable client.rgw.{{ hostvars[inventory_hostname]['ansible_hostname'] }} with the name of the section client.rgw.ceph-osd0, when it should compare the value of the variable with the name of the section.
The solution should probably be something along the line of translating
client.rgw.{{ hostvars[inventory_hostname]['ansible_hostname'] }} to client.rgw.ceph-osd0 (for example)
before adding the new sections

[alfredodeza]

jenkins test ansible2.2-xenial-cluster

[alfredodeza]

jenkins test this please

[alimaredia]

@leseb I tried running this branch and found that there was an extra endif here (

ceph-ansible/roles/ceph-common/templates/ceph.conf.j2

Line 127 in a9a4cb8

{% endif %}

) that caused ceph-ansible to error. Should I go ahead and fix that?

[leseb]

@alimaredia thanks for reporting this, I just pushed a new version.

[guits]

jenkins test kraken-ansible2.2-docker_dmcrypt_journal_collocation

[guits]

jenkins test kraken-ansible2.2-docker_dmcrypt_journal_collocation

[guits]

jenkins test jewel-ansible2.2-update_docker_cluster

[guits]

jenkins test kraken-ansible2.2-update_docker_cluster

[guits]

jenkins test jewel-ansible2.2-update_docker_cluster

[guits]

jenkins test jewel-ansible2.2-update_docker_cluster

[guits]

jenkins test jewel-ansible2.2-update_docker_cluster

[leseb]

jenkins test jewel-ansible2.2-update_docker_cluster

[guits]

jenkins test jewel-ansible2.2-update_docker_cluster

[guits]

jenkins test jewel-ansible2.2-update_docker_cluster

[ceph-jenkins]

OK - luminous-ansible2.2-journal_collocation

[leseb]

jenkins test jewel-ansible2.2-dmcrypt_journal_collocation

[leseb]

jenkins test jewel-ansible2.2-xenial_cluster

[leseb]

jenkins test luminous-ansible2.2-xenial_cluster

[leseb]

jenkins test luminous-ansible2.2-docker_cluster