tests: adds a purge_cluster_collocated scenario #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR needs ceph/ceph-build#605 for the |
alfredodeza
reviewed
Jan 3, 2017
| --extra-vars="ireallymeanit=yes fetch_directory={changedir}/fetch" | ||
| purge_cluster_collocated: ansible-playbook -vv -i {changedir}/hosts {toxinidir}/{env:PLAYBOOK:site.yml.sample} --extra-vars="fetch_directory={changedir}/fetch" | ||
|
|
||
| purge_cluster_collocated: testinfra -n 4 --sudo -v --connection=ansible --ansible-inventory={changedir}/hosts {toxinidir}/tests/functional/tests |
There was a problem hiding this comment.
do we have tests that check actual cluster purging?
There was a problem hiding this comment.
what it's testing here is that after purging we can bring the cluster back up in the correct state.
alfredodeza
reviewed
Jan 3, 2017
| @@ -39,4 +41,9 @@ commands= | |||
| ansible-playbook -vv -i {changedir}/hosts {toxinidir}/tests/functional/setup.yml | |||
|
|
|||
| testinfra -n 4 --sudo -v --connection=ansible --ansible-inventory={changedir}/hosts {toxinidir}/tests/functional/tests | |||
|
|
|||
| purge_cluster_collocated: ansible-playbook -vv -i {changedir}/hosts {toxinidir}/infrastructure-playbooks/purge-cluster.yml --extra-vars="ireallymeanit=yes fetch_directory={changedir}/fetch" | |||
| purge_cluster_collocated: ansible-playbook -vv -i {changedir}/hosts {toxinidir}/{env:PLAYBOOK:site.yml.sample} --extra-vars="fetch_directory={changedir}/fetch" | |||
There was a problem hiding this comment.
this wasn't immediately apparent to me (2 calls to ansible, one to purge another one to set everything up again)
can you add a simple comment just before this?
Using failed_when will still throw an exception and stop the playbook if the file you're trying to include doesn't exist. Signed-off-by: Andrew Schoen <aschoen@redhat.com>
In my testing zapping the osd disks deleted the journal partitions, making the 'zap ceph journal partitions' task fail because the partitions it found previously do not exist anymore. This moves the task that finds the journal partitions after 'zap osd disks' to catch any partitions ceph-disk might have missed. Signed-off-by: Andrew Schoen <aschoen@redhat.com>
This scenario brings up a 1 mon 1 osd cluster using journal collocation, purges the cluster and then verifies it can redeploy the cluster. Signed-off-by: Andrew Schoen <aschoen@redhat.com>
andrewschoen
force-pushed
the
purge-cluster-tests
branch
from
e46475e
to
0ce18da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test verifies that you can purge a cluster using journal collocation and then redeploy the cluster again. There were some minor fixes to
purge-cluster.ymlneeded for the playbook to work.