Adds failure checking if OSD is not created #2599

trozet · 2018-05-16T18:04:07Z

There are several different types of OSD that may be created depending
on a users environment/settings. However, in the case that no
conditions are met for OSD creation, ceph-ansible completes and no OSD
is created.

resolves #2598

leseb · 2018-05-17T15:07:33Z

roles/ceph-osd/tasks/scenarios/non-collocated.yml

@@ -70,6 +80,11 @@
    - not containerized_deployment
    - item.0.partitions|length == 0

+  register: osd


This won't work because of the changed_when: false.

why is this task set to changed_when false? Can we change it? It isn't present in the same command for manually prepare ceph.

nvm I'll work around it

leseb · 2018-05-17T15:08:09Z

roles/ceph-osd/tasks/scenarios/collocated.yml

@@ -2,6 +2,8 @@
 # use shell rather than docker module
 # to ensure osd disk prepare finishes before
 # starting the next task
+- set_fact: osd_created=False


- name: set_fact osd_created set_fact: osd_created: False

leseb · 2018-05-17T15:09:41Z

roles/ceph-osd/tasks/scenarios/collocated.yml

@@ -26,6 +28,10 @@
    - not osd_auto_discovery
    - containerized_deployment
    - item.0.partitions|length == 0
+  register: osd


Calling the register the same name won't work since ansible will overwrite the previous one, even if the task is skipped. So you have to use different names for each task.

That's the point. I want it to overwrite each one because the real state variable is osd_created

Yes, in this approach there is no issue to register multiple times the same variable name.
It might be an issue if we wanted to have the possibility to deploy multiple osd scenario per host though.

@guits Is that supported today? Are you asking me to change it or this is OK?

@trozet this is OK, I was just trying to clarify.

leseb · 2018-05-17T15:12:32Z

roles/ceph-osd/tasks/scenarios/collocated.yml

looks like this is fixing a different bug, which means you need a separate commit for that.

oops. I must have accidentally done that with copy paste. Will remove.

leseb · 2018-05-18T13:47:52Z

@trozet let us know when this is ready for review again.

trozet · 2018-05-18T14:13:19Z

@leseb please review again when you have a moment.

leseb · 2018-05-18T16:26:30Z

roles/ceph-osd/tasks/scenarios/collocated.yml

+- fail:
+    msg: >
+      OSD was never created.  If using not using osd_auto_discovery, ensure the


extra space between . and If.

I usually use 2 spaces after periods. I'll change them all to 1.

leseb · 2018-05-18T16:33:09Z

roles/ceph-osd/tasks/scenarios/non-collocated.yml

+      - "{{ parted_results.results | default([]) }}"
+      - "{{ devices }}"
+      - "{{ dedicated_devices }}"
+    changed_when: false


Doesn't this break the register line 99? https://github.com/ceph/ceph-ansible/pull/2599/files#diff-bc1034a6fab2180f375254c274e02ed6R99

Can you elaborate on your comment some more? I'm not sure what you think may not work with the register on 99.

@leseb are you concerned because of the changed_when: false because it's changing the "changed" attribute of a registered variable ? If yes, the register L99 isn't affected since they are not applied on the same task.

Yeah my bad, missed the indent and the block :). Not an issue.

leseb · 2018-05-18T16:33:13Z

roles/ceph-osd/tasks/scenarios/non-collocated.yml

+- fail:
+    msg: >
+      OSD was never created.  Ensure the specified devices do not have


guits · 2018-05-22T06:49:45Z

roles/ceph-osd/tasks/scenarios/collocated.yml

@@ -2,6 +2,10 @@
 # use shell rather than docker module


this comment should be moved L9

guits · 2018-05-22T06:55:30Z

roles/ceph-osd/tasks/scenarios/collocated.yml

@@ -26,6 +30,10 @@
    - not osd_auto_discovery
    - containerized_deployment
    - item.0.partitions|length == 0
+  register: osd
+
+- set_fact: osd_created=True


please, use the same syntax than above (L5-7, which is what we use in the whole playbook)

guits · 2018-05-22T06:55:51Z

roles/ceph-osd/tasks/scenarios/non-collocated.yml

@@ -28,6 +32,10 @@
    - containerized_deployment
    - osd_objectstore == 'filestore'
    - item.0.partitions|length == 0
+  register: osd
+
+- set_fact: osd_created=True


guits · 2018-05-22T06:56:00Z

roles/ceph-osd/tasks/scenarios/non-collocated.yml

-    - "{{ devices }}"
-    - "{{ dedicated_devices }}"
-  changed_when: false
+- set_fact: osd_created=True


guits · 2018-05-22T06:56:07Z

roles/ceph-osd/tasks/scenarios/non-collocated.yml

+      - "{{ dedicated_devices }}"
+    changed_when: false
+
+  - set_fact: osd_created=True


@trozet you missed this one ;)

guits · 2018-05-22T06:56:15Z

roles/ceph-osd/tasks/scenarios/non-collocated.yml

+  register: osd
+
+- set_fact: osd_created=True


guits · 2018-05-23T03:31:40Z

@trozet did you push your changes?

trozet · 2018-05-23T15:43:54Z

@guits @leseb just pushed new patch set

guits · 2018-05-23T16:58:53Z

roles/ceph-osd/tasks/scenarios/non-collocated.yml

+      - "{{ dedicated_devices }}"
+    changed_when: false
+
+  - set_fact: osd_created=True


@trozet you missed this one ;)

trozet · 2018-05-23T19:34:19Z

@guits please review again

leseb

sorry, one more thing.

leseb · 2018-05-23T19:48:46Z

roles/ceph-osd/tasks/scenarios/collocated.yml

+  when: osd.changed
+
+- name: fail if OSD was never created


oops missed this one, no uppercase in name's task.

@leseb done. Out of curiosity is that an ansible standards type of thing? Or is that just something decided on for this particular project?

This is something we decided on this particular project.

leseb · 2018-05-23T19:48:57Z

roles/ceph-osd/tasks/scenarios/non-collocated.yml

+  when: osd.changed
+
+- name: fail if OSD was never created


guits · 2018-05-23T20:00:16Z

jenkins test luminous-ansible2.4-docker_cluster

guits · 2018-05-23T20:00:36Z

jenkins test luminous-ansible2.4-bluestore_osds_non_container

guits · 2018-05-30T11:20:29Z

@trozet could you please rebase on master?

trozet · 2018-06-11T19:33:27Z

@guits sorry I missed this. Will rebase.

There are several different types of OSD that may be created depending on a users environment/settings. However, in the case that no conditions are met for OSD creation, ceph-ansible completes and no OSD is created. resolves ceph#2598 Signed-off-by: Tim Rozet <trozet@redhat.com>

guits · 2018-06-11T19:49:38Z

jenkins test this please

leseb · 2018-10-19T12:14:59Z

It'd be nice to resurrect something similar once #3187 merges.

leseb · 2018-12-20T13:33:28Z

Closing this due to inactivity, feel free to re-open, thanks!

leseb changed the title ~~Adds failure checking if OSD is not created~~ [skip ci] Adds failure checking if OSD is not created May 17, 2018

leseb requested changes May 17, 2018

View reviewed changes

trozet force-pushed the add_osd_creation_check branch 2 times, most recently from 4c8cc1d to ee92b95 Compare May 18, 2018 14:12

leseb requested changes May 18, 2018

View reviewed changes

guits requested changes May 22, 2018

View reviewed changes

trozet force-pushed the add_osd_creation_check branch from ee92b95 to 083456e Compare May 23, 2018 15:42

guits requested changes May 23, 2018

View reviewed changes

trozet force-pushed the add_osd_creation_check branch from 083456e to ba2cf6f Compare May 23, 2018 19:33

leseb requested changes May 23, 2018

View reviewed changes

trozet force-pushed the add_osd_creation_check branch from ba2cf6f to 1bb5d81 Compare May 23, 2018 19:55

guits previously approved these changes May 23, 2018

View reviewed changes

guits changed the title ~~[skip ci] Adds failure checking if OSD is not created~~ Adds failure checking if OSD is not created May 23, 2018

leseb previously approved these changes May 23, 2018

View reviewed changes

leseb changed the title ~~Adds failure checking if OSD is not created~~ [skip ci] Adds failure checking if OSD is not created May 24, 2018

trozet dismissed stale reviews from leseb and guits via f4a0973 June 11, 2018 19:38

trozet force-pushed the add_osd_creation_check branch from 1bb5d81 to f4a0973 Compare June 11, 2018 19:38

guits changed the title ~~[skip ci] Adds failure checking if OSD is not created~~ Adds failure checking if OSD is not created Jun 11, 2018

leseb closed this Dec 20, 2018

Adds failure checking if OSD is not created #2599

Adds failure checking if OSD is not created #2599

Conversation

trozet commented May 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leseb commented May 18, 2018

trozet commented May 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guits commented May 23, 2018

trozet commented May 23, 2018

Choose a reason for hiding this comment

trozet commented May 23, 2018

leseb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leseb May 23, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guits commented May 23, 2018

guits commented May 23, 2018

guits commented May 30, 2018

trozet commented Jun 11, 2018

guits commented Jun 11, 2018

leseb commented Oct 19, 2018

leseb commented Dec 20, 2018

leseb May 23, 2018 •

edited