Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gwcli can hang due to hang of rbd-target-api #131

Open
michael-db opened this issue Aug 20, 2019 · 0 comments
Open

gwcli can hang due to hang of rbd-target-api #131

michael-db opened this issue Aug 20, 2019 · 0 comments

Comments

@michael-db
Copy link

I've seen rbd-target-api go into an uninterruptible sleep (a state very difficult to debug).
Starting gwcli in this circumstance leads it to completely hang on doing

        api = APIRequest(endpoint + "/config")
        api.get()

The hang in gwcli at least is avoidable. My quick fix for that was to add these lines to gwcli/utils.py APIRequest.init():

        if 'verify' not in self.kwargs:
            self.kwargs['verify'] = settings.config.api_ssl_verify
        ##### added this: #####
        if 'timeout' not in self.kwargs:
            self.kwargs['timeout'] = 20

(Though the error handling would also best be improved so that a timeout leads to an appropriate message rather than an "unknown error".)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant