Skip to content

Commit

Permalink
MDSMonitor: do not assign standby-replay when degraded
Browse files Browse the repository at this point in the history
The journal (or potentially other rank metadata) may be in the process of being
migrated or modified.

Fixes: http://tracker.ceph.com/issues/36384
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
  • Loading branch information
batrick committed Feb 15, 2019
1 parent 6f3fda6 commit 065e98e
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/mon/MDSMonitor.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1915,9 +1915,10 @@ bool MDSMonitor::maybe_promote_standby(FSMap &fsmap, std::shared_ptr<Filesystem>
do_propose = true;
}
}
} else {
} else if (!fs->mds_map.is_degraded()) {
// There were no failures to replace, so try using any available standbys
// as standby-replay daemons.
// as standby-replay daemons. Don't do this when the cluster is degraded
// as a standby-replay daemon may try to read a journal being migrated.

// Take a copy of the standby GIDs so that we can iterate over
// them while perhaps-modifying standby_daemons during the loop
Expand Down

0 comments on commit 065e98e

Please sign in to comment.