Skip to content

Commit

Permalink
Merge pull request #5371 from dachary/wip-12494-hammer
Browse files Browse the repository at this point in the history
ceph tell: broken error message / misleading hinting

Reviewed-by: Loic Dachary <ldachary@redhat.com>
  • Loading branch information
Loic Dachary committed Aug 30, 2015
2 parents 53cdcf2 + e004941 commit 4675971
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/ceph.in
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,7 @@ def main():
if len(childargs) >= 2 and \
childargs[0] in ['mon', 'osd'] and \
childargs[1] == 'tell':
print >> sys.stderr, '"{0} tell" is deprecated; try "tell {0}.<id>" instead (id can be "*") '.format(childargs[0])
print >> sys.stderr, '"{0} tell" is deprecated; try "tell {0}.<id> <command> [options...]" instead (id can be "*") '.format(childargs[0])
return 1

if parsed_args.help:
Expand Down Expand Up @@ -794,7 +794,9 @@ def main():
childargs = injectargs
if not len(childargs):
print >> sys.stderr, \
'Cannot use \'tell\' with interactive mode'
'Cannot use \'tell\' with interactive mode.', \
'For an interactive shell,', \
'please start "{0}" without non-option arguments.'.format(sys.argv[0])
return errno.EINVAL

# fetch JSON sigs from command
Expand Down

0 comments on commit 4675971

Please sign in to comment.