client/filer: cleanup the redundant judgments of _write&&_fallocate #10062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The running time of redundant judgments influence function,especially _write(), at the same time,Filer::read/read_trunc/write/write_trunc/truncate/zero type should be void, fix it Signed-off-by: huanwen ren <ren.huanwen@zte.com.cn>
renhwztetecs
changed the title
|
Was there something that led you to make these changes? I mean, they might be fine, but there's nothing inherent about the functions that prevents them from returning error codes, just the current implementation. And I have a hard time believing anything you've removed makes a material difference to throughput. |
|
@gregsfortytwo |
renhwztetecs
changed the title
|
Reviewed-by Performance aside, I'm in favour of always-succeed functions being void. For external interfaces I see the value of returning int in case we want to change the implementation, but internally I prefer void. |
|
@jcsp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The running time of redundant judgments influence function,especially _write(),
at the same time,Filer::read/read_trunc/write/write_trunc/truncate/zero type should be void, fix it
Signed-off-by: huanwen ren ren.huanwen@zte.com.cn