CephFS: misc. cleanups and remove legacy cephfs tool #10243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a line Fixes: http://tracker.ceph.com/issues/16035 to d67affc ? |
added 4 commits
July 19, 2016 13:59
Removing this check allows us to finally move the Objecter instance down into MDSRank where it belongs. Fixes: http://tracker.ceph.com/issues/15923 Signed-off-by: John Spray <john.spray@redhat.com>
Previously this returned 0 and an empty response, which in turn upsets the python code that calls commands. Signed-off-by: John Spray <john.spray@redhat.com>
This has been deprecated for quite some time, in favour of using proper vxattr and libcephfs interfaces. Fixes: http://tracker.ceph.com/issues/16035 Signed-off-by: John Spray <john.spray@redhat.com>
Fixes: http://tracker.ceph.com/issues/16195 Signed-off-by: John Spray <john.spray@redhat.com>
|
@smithfarm it already had the Fixes line I think? Pushed a rebase of this anyway. I'd suggest that the ceph-common/ceph-fs-common refactor be done separately to this PR Any objections to merging? |
Definitely not! I am eager to remove the legacy tool. |
|
I looked at the test failures, which fall into the following categories:
|
|
JFYI, I opened http://tracker.ceph.com/issues/16808 for the ceph-common/ceph-fs-common refactor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.