rgw: fix upgrade from old multisite to new multisite configuration #10368
Conversation
We need to store the updated current period after adding the old converted regions Fixes: http://tracker.ceph.com/issues/16751 Signed-off-by: Orit Wasserman <owasserm@redhat.com>
oritwas
force-pushed
the
wip-rgw-upgrade-period-commit
branch
from
1c949ec
to
6d7841c
Compare
| if (ret < 0) { | ||
| ldout(cct, 0) << "failed init zonegroup" << iter << ": ret "<< ret << " " << cpp_strerror(-ret) << dendl; | ||
| return ret; | ||
| } |
There was a problem hiding this comment.
is it possible to avoid reloading the zonegroup here? it doesn't look like delete_obj() really depends on this when old_format=true
There was a problem hiding this comment.
I moved the cleanup to the end so user can keep the old config in case of a failed conversion but it requires to reload the region.
We are deleting the old regions, the flag old_format has to be set otherwise we will delete the new zonegroups
There was a problem hiding this comment.
i understand the logic, and everything looks correct to me. i was just suggesting an optimization by skipping the step where we reload the zonegroup from rados. but optimizing the upgrade is probably wasted effort. :)
if you're satisfied with testing, i'm happy to merge 👍
We need to store the updated current period after adding the old converted regions
Fixes: http://tracker.ceph.com/issues/16751
Signed-off-by: Orit Wasserman owasserm@redhat.com