rgw: clean up RGWShardedOmapCRManager on early return #11505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShardedOmapCRManager is spawning coroutines that sleep. if we don't finish them before trying to drain_all(), they'll lead to deadlock Fixes: http://tracker.ceph.com/issues/17571 Signed-off-by: Casey Bodley <cbodley@redhat.com>
|
@cbodley lgtm, do we need to run specific tests on this one? |
|
@yehudasa this one would be hard to reproduce in the absence of other bugs i would (someday) love to hook up unit tests to each of these coroutines so we can get coverage of the error paths, but it'll take some work to be able to pass in mocks for each of the child crs they spawn. would you like me to try FetchAllMetaCR as a start? |
|
@cbodley sounds good |
|
unit tests added as separate pr - they succeed when this fix is applied, and deadlock without |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShardedOmapCRManager is spawning coroutines that sleep. if we don't
finish them before trying to drain_all(), they'll lead to deadlock
Fixes: http://tracker.ceph.com/issues/17571