rocksdb: do not build with --march=native #11677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we can not assume that building host has the same arch (or the same cpu capability) with the target machine. Signed-off-by: Kefu Chai <kchai@redhat.com>
|
LGTM |
|
lgtm |
|
How should we fix this upstream in rocksdb so that we don't have to carry this patch? Add a cmake option? |
|
change posted to upstream facebook/rocksdb#1429 |
|
@liewegas patch submitted to upstream. if we really want to have some optimization on some arch, for example i686. we should be using a toolchain cmake file to customize the CCFLAGS, etc. and use it instead. |
|
i am merging this change in hope to bring the master branch back to normal before it takes too long to wait until the test passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can not assume that building host has the same arch (or the same cpu
capability) with the target machine.
Signed-off-by: Kefu Chai kchai@redhat.com