osdmaptool: add --test-map-pgs mode #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (test_random) { | ||
| osds.resize(p->second.size); | ||
| for (unsigned i=0; i<osds.size(); ++i) { | ||
| osds[i] = rand() % osdmap.get_max_osd(); |
There was a problem hiding this comment.
this code may generate repeated osd.
There was a problem hiding this comment.
that's okay. this is just to sanity-check the calculation for expected standard deviation and get a sense for what the min/max spread would be for a truly uniform distribution.
|
looks good |
ghost
mentioned this pull request
| @@ -3,6 +3,10 @@ | |||
| usage: [--print] [--createsimple <numosd> [--clobber] [--pg_bits <bitsperosd>]] <mapfilename> | |||
| --export-crush <file> write osdmap's crush map to <file> | |||
| --import-crush <file> replace osdmap's crush map with <file> | |||
| --test-map-pgs map all pgs | |||
| --mark-all-up-in mark osds up and in (but do not persist) | |||
|
👍 after the typo is fixed |
|
Added tests to better understand how it works #1196 |
This command will map all pgs from all pools (or just one pool) to osds and summarize the placement and calculate the actual standard deviation and the expected value. Signed-off-by: Sage Weil <sage@inktank.com>
This useful for comparison purposes and sanity-checking the results. Signed-off-by: Sage Weil <sage@inktank.com>
Signed-off-by: Sage Weil <sage@inktank.com>
Signed-off-by: Loic Dachary <loic@dachary.org>
Signed-off-by: Loic Dachary <loic@dachary.org>
Signed-off-by: Loic Dachary <loic@dachary.org>
liewegas
pushed a commit
that referenced
this pull request
Feb 7, 2014
osdmaptool: add --test-map-pgs mode Reviewed-by: Yan, Zheng <zheng.z.yan@intel.com> Reviewed-by: Loic Dachary <loic@dachary.org>
liewegas
pushed a commit
that referenced
this pull request
Dec 14, 2016
smoke: mask out unsupported image features for krbd iozone test Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command will map all pgs from all pools (or just one pool) to osds and
summarize the placement and calculate the actual standard deviation and the
expected value.
Signed-off-by: Sage Weil sage@inktank.com