New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw/rgw_main.cc: fix parenteses and function result #12295

Merged
merged 1 commit into from Feb 21, 2017

Conversation

Projects
None yet
4 participants
@wjwithagen
Contributor

wjwithagen commented Dec 3, 2016

  • The function in the macro parameter is expected to return -1 i
    on error and not type(bool).
    So reorganize the parenteses and just pass dup2() to the macro.

Signed-off-by: Willem Jan Withagen wjw@digiware.nl

rgw/rgw_main.cc: fix parenteses and function result
 - The function in the macro parameter is expected to return -1 i
   on error and not type(bool).
   So reorganize the parenteses and just pass dup2() to the macro.

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented Dec 5, 2016

@tchaikov
I guess that this needs to run thru QA as well?
The change is minute, and should not trip anything. But you never know

@mattbenjamin

lgtm

@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented Jan 4, 2017

@tchaikov
Would you care looking at this one as well?

@tchaikov tchaikov self-assigned this Jan 4, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jan 10, 2017

@wjwithagen it's just pending on a rgw qa run.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jan 19, 2017

@mattbenjamin could you include this PR in your next batch of qa run?

@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented Feb 1, 2017

@mattbenjamin
Could you have a look at this?
Not going to say it is trivial, but then again it is not real complex either

@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented Feb 21, 2017

@tchaikov @mattbenjamin
Any particulars why this cannot be merged?

@tchaikov tchaikov merged commit 4454340 into ceph:master Feb 21, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented Feb 21, 2017

@tchaikov
Thanx

@wjwithagen wjwithagen deleted the wjwithagen:wip-wjw-TEMP_FAILURE branch Feb 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment