ceph-disk: dmcrypt activate must use the same cluster as prepare #13573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
ghost
changed the title
When dmcrypt is used, the fsid cannot be retrieved from the data partition because it is encrypted. Store the fsid in the lockbox to enable dmcrypt activation using the same logic as regular activation. The fsid is used to retrive the cluster name that was used during prepare, reason why activation does not and must not have a --cluster argument. Fixes: http://tracker.ceph.com/issues/17821 Signed-off-by: Loic Dachary <ldachary@redhat.com>
ghost
changed the title
teuthology-suite -k distro --verbose --suite ceph-disk --ceph wip-17821-revert --machine-type vps pass http://pulpito.ceph.com/loic-2017-02-22_05:31:46-ceph-disk-wip-17821-revert-distro-basic-vps |
|
teuthology suite for ceph-disk passes #13573 (comment) |
|
There are no specific tests for this change. But it modifies the code path used by every dmcrypt activation and I believe that's enough coverage, via the teuthology ceph-disk suite, to prove it does the right thing. |
tchaikov
approved these changes
Feb 22, 2017
|
@leseb the backport is in progress at #13496 . It looks like Loic has requested changes of the reviewer. If this needs to get into v10.2.7, please work with @shinobu-x on that. At this point in the schedule anything for v10.2.7 must have Pulpito links to successful Teuthology runs demonstrating that the change is safe to take in. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dmcrypt is used, the fsid cannot be retrieved from the data
partition because it is encrypted. Store the fsid in the lockbox to
enable dmcrypt activation using the same logic as regular activation.
The fsid is used to retrive the cluster name that was used during
prepare, reason why activation does not and must not have a --cluster
argument.
Fixes: http://tracker.ceph.com/issues/17821
Signed-off-by: Loic Dachary ldachary@redhat.com