-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arch: fix build on PowerPC with FreeBSD #14378
Conversation
The #include file <sys/auxv.h> is present on linux but not FreeBSD. Move it under the #if __linux__ directive. Signed-off-by: Andrew Solomon <asolomon@us.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specifically on FreeBSD this will allow compilation on PPC archs without hte auxv.h file.
Which can improve portability.
Looks like perhaps something may be wrong with one of the gate checks? |
@kestrel could you be more specific? what i found from a quick check is that |
I'm not talking about any checks in the source code, I'm talking about the gate checks for this pull request that say "Some checks haven't completed yet". In particular the one that says "default - Waiting for status to be reported". Is that normal / expected? |
it's not normal or expected. seems the jenkins job is stalled somehow. |
retest this please. |
retest this please |
the timeout should have been fixed in master. |
The #include file <sys/auxv.h> is present on linux but
not FreeBSD. Move it under the #if linux directive.
Signed-off-by: Andrew Solomon asolomon@us.ibm.com