Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch: fix build on PowerPC with FreeBSD #14378

Merged
merged 1 commit into from
Apr 10, 2017
Merged

Conversation

kestrels
Copy link
Contributor

@kestrels kestrels commented Apr 6, 2017

The #include file <sys/auxv.h> is present on linux but
not FreeBSD. Move it under the #if linux directive.

Signed-off-by: Andrew Solomon asolomon@us.ibm.com

The #include file <sys/auxv.h> is present on linux but
not FreeBSD.  Move it under the #if __linux__ directive.

Signed-off-by: Andrew Solomon <asolomon@us.ibm.com>
@wjwithagen wjwithagen self-requested a review April 6, 2017 21:30
Copy link
Contributor

@wjwithagen wjwithagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifically on FreeBSD this will allow compilation on PPC archs without hte auxv.h file.
Which can improve portability.

@tchaikov tchaikov changed the title build: src/arch/ppc.c FreeBSD build break arch: fix build on PowerPC with FreeBSD Apr 7, 2017
@kestrels
Copy link
Contributor Author

kestrels commented Apr 7, 2017

Looks like perhaps something may be wrong with one of the gate checks?

@tchaikov
Copy link
Contributor

tchaikov commented Apr 7, 2017

@kestrel could you be more specific? what i found from a quick check is that common/crc32c_ppc.c and common/crc32c_intel_fast.c should be conditionalized in the CMakeLists.txt.

@kestrels
Copy link
Contributor Author

kestrels commented Apr 7, 2017

I'm not talking about any checks in the source code, I'm talking about the gate checks for this pull request that say "Some checks haven't completed yet". In particular the one that says "default - Waiting for status to be reported". Is that normal / expected?

@tchaikov
Copy link
Contributor

tchaikov commented Apr 7, 2017

it's not normal or expected. seems the jenkins job is stalled somehow.

@tchaikov
Copy link
Contributor

tchaikov commented Apr 7, 2017

retest this please.

@liewegas
Copy link
Member

liewegas commented Apr 8, 2017

retest this please

@tchaikov
Copy link
Contributor

The following tests FAILED:
	  3 - ceph_objectstore_tool.py (Timeout)

the timeout should have been fixed in master.

@tchaikov tchaikov merged commit 6caa1b6 into ceph:master Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants