New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch: fix build on PowerPC with FreeBSD #14378

Merged
merged 1 commit into from Apr 10, 2017

Conversation

Projects
None yet
4 participants
@kestrels
Contributor

kestrels commented Apr 6, 2017

The #include file <sys/auxv.h> is present on linux but
not FreeBSD. Move it under the #if linux directive.

Signed-off-by: Andrew Solomon asolomon@us.ibm.com

build: src/arch/ppc.c FreeBSD build break
The #include file <sys/auxv.h> is present on linux but
not FreeBSD.  Move it under the #if __linux__ directive.

Signed-off-by: Andrew Solomon <asolomon@us.ibm.com>

@wjwithagen wjwithagen self-requested a review Apr 6, 2017

@wjwithagen

Specifically on FreeBSD this will allow compilation on PPC archs without hte auxv.h file.
Which can improve portability.

@tchaikov tchaikov changed the title from build: src/arch/ppc.c FreeBSD build break to arch: fix build on PowerPC with FreeBSD Apr 7, 2017

@kestrels

This comment has been minimized.

Show comment
Hide comment
@kestrels

kestrels Apr 7, 2017

Contributor

Looks like perhaps something may be wrong with one of the gate checks?

Contributor

kestrels commented Apr 7, 2017

Looks like perhaps something may be wrong with one of the gate checks?

@tchaikov

This comment has been minimized.

Show comment
Hide comment
@tchaikov

tchaikov Apr 7, 2017

Contributor

@kestrel could you be more specific? what i found from a quick check is that common/crc32c_ppc.c and common/crc32c_intel_fast.c should be conditionalized in the CMakeLists.txt.

Contributor

tchaikov commented Apr 7, 2017

@kestrel could you be more specific? what i found from a quick check is that common/crc32c_ppc.c and common/crc32c_intel_fast.c should be conditionalized in the CMakeLists.txt.

@kestrels

This comment has been minimized.

Show comment
Hide comment
@kestrels

kestrels Apr 7, 2017

Contributor

I'm not talking about any checks in the source code, I'm talking about the gate checks for this pull request that say "Some checks haven't completed yet". In particular the one that says "default - Waiting for status to be reported". Is that normal / expected?

Contributor

kestrels commented Apr 7, 2017

I'm not talking about any checks in the source code, I'm talking about the gate checks for this pull request that say "Some checks haven't completed yet". In particular the one that says "default - Waiting for status to be reported". Is that normal / expected?

@tchaikov

This comment has been minimized.

Show comment
Hide comment
@tchaikov

tchaikov Apr 7, 2017

Contributor

it's not normal or expected. seems the jenkins job is stalled somehow.

Contributor

tchaikov commented Apr 7, 2017

it's not normal or expected. seems the jenkins job is stalled somehow.

@tchaikov

This comment has been minimized.

Show comment
Hide comment
@tchaikov

tchaikov Apr 7, 2017

Contributor

retest this please.

Contributor

tchaikov commented Apr 7, 2017

retest this please.

@liewegas liewegas added the build/ops label Apr 8, 2017

@liewegas

This comment has been minimized.

Show comment
Hide comment
@liewegas

liewegas Apr 8, 2017

Member

retest this please

Member

liewegas commented Apr 8, 2017

retest this please

@tchaikov

This comment has been minimized.

Show comment
Hide comment
@tchaikov

tchaikov Apr 10, 2017

Contributor
The following tests FAILED:
	  3 - ceph_objectstore_tool.py (Timeout)

the timeout should have been fixed in master.

Contributor

tchaikov commented Apr 10, 2017

The following tests FAILED:
	  3 - ceph_objectstore_tool.py (Timeout)

the timeout should have been fixed in master.

@tchaikov tchaikov merged commit 6caa1b6 into ceph:master Apr 10, 2017

2 of 3 checks passed

default Build finished.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment