tools: release-notes minor fixes #14632
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
theanalyst
commented
Apr 19, 2017
•
theanalyst
commented
- don't check for duplicate pr titles when commit messages have an empty description
- minor fixes for split component
- make labels a set
- have more options for prefixes via a union with existing prefixes
- sort results of prefixes before creating title
Since `duplicate_pr_title` is only set when we have a line, set the boolean as False and set a value only if we can find a value for the line Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
make labels a set as intersection would fail otherwise, also sort the results of prefixes before creating the title Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
smithfarm
reviewed
Apr 19, 2017
| @@ -104,9 +104,9 @@ def split_component(title, gh, number): | |||
| issue_labels = {it['name'] for it in issue['labels']} | |||
| if 'documentation' in issue_labels: | |||
| return 'doc: ' + title | |||
| item = labels.intersection(issue_labels) | |||
| item = (labels.union(set(prefixes))).intersection(issue_labels) | |||
There was a problem hiding this comment.
What is the purpose of combining labels with prefixes? Will issue_labels ever match an element of prefixes that is not already in labels?
There was a problem hiding this comment.
Hm I looked at this wrong, what I wanted is if the pr is not labeled and there is a prefix that matches then we pass instead of returning unknown which we're doing now, this requires one more modification, I'll look into it.
|
Looks like #14385 does not conflict, but it would be nice if it could be merged along with this one. |
|
@smithfarm sorry for leaving that open, merged, |
|
@smithfarm @dachary ping? |
|
@tchaikov sorry for letting this rot, I need to make one more fix before we merge |
|
part of #16605 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.