yasm-wrapper: strip -E (stops ccache trashing source files) #14633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building with ccache (`./do_cmake.sh -DWITH_CCACHE=ON`), it seems ccache invokes `yast-wrapper` more than once per source file, the first time with '-E' immediately before the source file in the argument list. '-E' is an option for gcc which tells it to stop after the preprocessing stage. With yasm however, -E means "redirect error messages to file", which makes yasm thinks there's no input files, and writes "yasm: No input files specified" *over* the source file. Then, the second run of `yast-wrapper` (attempting to actually compile) fails with: ~/src/common/crc32c_intel_fast_asm.S:1: error: instruction expected after label Curiously, this doesn't seem to affect all asm files; for me it trashes crc32c_intel_fast_asm.S, but various other asm files build fine without being clobbered. I'm uncertain whether this is an issue peculiar to openSUSE Tumbleweed, to ccache 3.3.3, or something else, but in any case, having `yast-wrapper` strip '-E' fixes it. Signed-off-by: Tim Serong <tserong@suse.com>
tchaikov
approved these changes
Apr 19, 2017
bassam
added a commit
to bassam/ceph
that referenced
this pull request
May 17, 2017
Related to ceph#14633 use the yasm-wrapper to avoid compilation issues when using ccache. Signed-off-by: Bassam Tabbara <bassam.tabbara@quantum.com>
bassam
added a commit
to bassam/ceph
that referenced
this pull request
May 18, 2017
when building with -DWITH_CCACHE=ON recent versions of ccache (for example 3.3.3) seem to mangle object files from the cache for source files that have a .S extension. This seems similar but unrelated to PR ceph#14633. The workaround here is to rename .S files to .s (lower case). Signed-off-by: Bassam Tabbara <bassam.tabbara@quantum.com>
bassam
added a commit
to bassam/ceph
that referenced
this pull request
May 18, 2017
when building with -DWITH_CCACHE=ON recent versions of ccache (for example 3.3.3) seem to mangle object files from the cache for source files that have a .S extension. This seems similar but unrelated to PR ceph#14633. The workaround here is to rename .S files to .s (lower case). Signed-off-by: Bassam Tabbara <bassam.tabbara@quantum.com>
bassam
added a commit
to bassam/ceph
that referenced
this pull request
May 18, 2017
when building with -DWITH_CCACHE=ON recent versions of ccache (for example 3.3.3) seem to mangle object files from the cache for source files that have a .S extension. This seems similar but unrelated to PR ceph#14633. The workaround here is to rename .S files to .s (lower case). Signed-off-by: Bassam Tabbara <bassam.tabbara@quantum.com>
bassam
added a commit
to bassam/ceph
that referenced
this pull request
May 18, 2017
when building with -DWITH_CCACHE=ON recent versions of ccache (for example 3.3.3) seem to mangle object files from the cache for source files that have a .S extension. This seems similar but unrelated to PR ceph#14633. The workaround here is to rename .S files to .s (lower case). Signed-off-by: Bassam Tabbara <bassam.tabbara@quantum.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with ccache (
./do_cmake.sh -DWITH_CCACHE=ON), it seemsccache invokes
yast-wrappermore than once per source file, the firsttime with '-E' immediately before the source file in the argument list.
'-E' is an option for gcc which tells it to stop after the preprocessing
stage. With yasm however, -E means "redirect error messages to file",
which makes yasm thinks there's no input files, and writes "yasm: No input
files specified" over the source file. Then, the second run of
yast-wrapper(attempting to actually compile) fails with:~/src/common/crc32c_intel_fast_asm.S:1: error: instruction expected after label
Curiously, this doesn't seem to affect all asm files; for me it
trashes crc32c_intel_fast_asm.S, but various other asm files build fine
without being clobbered. I'm uncertain whether this is an issue
peculiar to openSUSE Tumbleweed, to ccache 3.3.3, or something else,
but in any case, having
yast-wrapperstrip '-E' fixes it.Signed-off-by: Tim Serong tserong@suse.com