ceph-disk: ceph-disk on FreeBSD should not use mpath-code #14837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwithagen
force-pushed
the
wip-wjw-freebsd-ceph-disk-mpath
branch
from
08fa4c2
to
9d430af
Compare
tchaikov
reviewed
Apr 29, 2017
src/ceph-disk/ceph_disk/main.py
Outdated
| dev, | ||
| ], | ||
| ) | ||
| if ret: |
There was a problem hiding this comment.
EXIT STATUS
The fstyp utility exits 0 on success, and >0 if an error occurs or the filesystem type is not recognized.
see http://www.unix.com/man-page/freebsd/8/fstyp/,
so should be if ret == 0, i guess?
|
On 29-04-17 02:42, Sage Weil wrote:
http://pulpito.ceph.com/sage-2017-04-29_00:40:18-ceph-disk-wip-sage-testing---basic-mira/
I'm having trouble interpreting the results there.
Looks like the 2 wrong tests too 5 and 1 hour to complete and the
correct test only 28 min.
And I only see not installed warnings...
Could it be that the faulty tests did not correctly start to begin with?
…--WjW
|
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
wjwithagen
force-pushed
the
wip-wjw-freebsd-ceph-disk-mpath
branch
from
9d430af
to
6727618
Compare
|
@wjwithagen i reran the ceph-disk suite at http://pulpito.ceph.com/kchai-2017-04-29_03:01:51-ceph-disk-wip-sage-testing---basic-vps/. and it passed. |
tchaikov
approved these changes
Apr 29, 2017
tchaikov
approved these changes
Apr 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Willem Jan Withagen wjw@digiware.nl