New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph-disk: ceph-disk on FreeBSD should not use mpath-code #14837

Merged
merged 1 commit into from Apr 29, 2017

Conversation

Projects
None yet
3 participants
@wjwithagen
Contributor

wjwithagen commented Apr 27, 2017

Signed-off-by: Willem Jan Withagen wjw@digiware.nl

dev,
],
)
if ret:

This comment has been minimized.

@tchaikov

tchaikov Apr 29, 2017

Contributor

EXIT STATUS
The fstyp utility exits 0 on success, and >0 if an error occurs or the filesystem type is not recognized.
see http://www.unix.com/man-page/freebsd/8/fstyp/,

so should be if ret == 0, i guess?

@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented Apr 29, 2017

ceph-disk: ceph-disk on FreeBSD should not use mpath-code
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 29, 2017

@tchaikov

lgtm. and the test suite passed. the latest change does not affect the change result.

@tchaikov tchaikov merged commit 2b9c9f0 into ceph:master Apr 29, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@wjwithagen wjwithagen deleted the wjwithagen:wip-wjw-freebsd-ceph-disk-mpath branch May 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment