Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osd/OSDMap: should update input param if osd dne #14863

Merged
merged 4 commits into from Apr 28, 2017
Merged

osd/OSDMap: should update input param if osd dne #14863

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6279736
test/test_async_driver: silence clang static analyzer warning
tchaikov Apr 28, 2017
cd514ba
common/obj_bencher: silence divide by zero warning
tchaikov Apr 28, 2017
8f2537f
osd/OSDMap: should update input param if osd dne
tchaikov Apr 28, 2017
c6337b4
common/hobject: use string::append() to avoid temp object
tchaikov Apr 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/osd/OSDMap.cc
View file
Open in desktop
Expand Up @@ -1663,7 +1663,7 @@ void OSDMap::_remove_nonexistent_osds(const pg_pool_t& pool,
if (removed)
osds.resize(osds.size() - removed);
} else {
for (auto osd : osds) {
for (auto& osd : osds) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!!

if (!exists(osd))
osd = CRUSH_ITEM_NONE;
}
Expand Down