Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists.txt: fix the manpage location for FreeBSD #14882

Closed
wants to merge 1 commit into from

Conversation

wjwithagen
Copy link
Contributor

Signed-off-by: Willem Jan Withagen wjw@digiware.nl

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
@tchaikov
Copy link
Contributor

we discussed this before, see #13301

@wjwithagen
Copy link
Contributor Author

I knew that I had discussion about this, but I thought it was at the FreeBSD end.
Your memory is way better than mine.

I guess that the resolution was to set a CMAKE var to actually fix this, then the new question becomes why my new ports tests runs are throwing a fit on the wrong location. AKA how did this setting get lost.
Perhaps putting this in, is a more future safe sollution?

@tchaikov
Copy link
Contributor

@wjwithagen i think we had reached a convergence. maybe you can reference do_freebsd.sh next time. if -DCEPH_MAN_DIR=man fails to work for you, then we need to fix it instead.

@liewegas liewegas changed the title ./CMakeLists.txt: fix the manpage location for FreeBSD CMakeLists.txt: fix the manpage location for FreeBSD Apr 30, 2017
@wjwithagen wjwithagen closed this Apr 30, 2017
@wjwithagen
Copy link
Contributor Author

@tchaikov
Closed the PR....
Not sure why it got lost on the FreeBSD port. But it (can be)|(needs to be_ there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants