qa/tasks/ceph_manager: always fix pgp_num when done with thrashosd task #14931
Conversation
Fixes: http://tracker.ceph.com/issues/19771 Signed-off-by: Kefu Chai <kchai@redhat.com>
|
we need to fix this in master, then backport it to kraken. |
| """ | ||
| Set pgpnum property of pool_name pool. | ||
| """ | ||
| with self.lock: | ||
| assert isinstance(pool_name, basestring) | ||
| assert pool_name in self.pools | ||
| if self.get_num_creating() > 0: |
There was a problem hiding this comment.
why does this expect to see creating pgs when it finishes anyway? maybe it should set pgp_num unconditionally, but block in a loop first waiting for creating pgs to get created?
There was a problem hiding this comment.
"fix_pgp_num" is also a thrashosd action. i guess the thrash tests are supposed to be quick. that's why we skip an action if the pool has pgs being created. in the case of "healthy" task, it will wait anyway, so no need to block in a loop for waiting the num_creating to be 0. so i think the current fix is good enough. what do you think?
|
all three runs passed. |
|
retest this please. |
|
@liewegas i think it's ready to merge. what do you think? |
Fixes: http://tracker.ceph.com/issues/19771
Signed-off-by: Kefu Chai kchai@redhat.com