New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/tasks/ceph_manager: always fix pgp_num when done with thrashosd task #14931

Merged
merged 1 commit into from May 5, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Contributor

tchaikov commented May 3, 2017

Fixes: http://tracker.ceph.com/issues/19771
Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov tchaikov requested review from liewegas and jdurgin May 3, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented May 3, 2017

we need to fix this in master, then backport it to kraken.

"""
Set pgpnum property of pool_name pool.
"""
with self.lock:
assert isinstance(pool_name, basestring)
assert pool_name in self.pools
if self.get_num_creating() > 0:

This comment has been minimized.

@liewegas

liewegas May 3, 2017

Member

why does this expect to see creating pgs when it finishes anyway? maybe it should set pgp_num unconditionally, but block in a loop first waiting for creating pgs to get created?

This comment has been minimized.

@tchaikov

tchaikov May 3, 2017

Contributor

"fix_pgp_num" is also a thrashosd action. i guess the thrash tests are supposed to be quick. that's why we skip an action if the pool has pgs being created. in the case of "healthy" task, it will wait anyway, so no need to block in a loop for waiting the num_creating to be 0. so i think the current fix is good enough. what do you think?

@tchaikov

This comment has been minimized.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented May 5, 2017

all three runs passed.

@tchaikov tchaikov requested a review from liewegas May 5, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented May 5, 2017

retest this please.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented May 5, 2017

@liewegas i think it's ready to merge. what do you think?

@liewegas liewegas merged commit 99928c9 into ceph:master May 5, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-19771 branch May 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment