New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: fix segfault in RevokeThread during its shutdown procedure. #15033

Merged
merged 2 commits into from Jul 26, 2017

Conversation

Projects
None yet
3 participants
@rzarzynski
Contributor

rzarzynski commented May 10, 2017

Fixes: http://tracker.ceph.com/issues/19831
Signed-off-by: Radoslaw Zarzynski rzarzynski@mirantis.com

@@ -224,7 +224,7 @@ class TokenCache {
friend class TokenCache;
typedef RGWPostHTTPData RGWGetRevokedTokens;
CephContext * const cct;
CephContext* const cct;

This comment has been minimized.

@rzarzynski

rzarzynski May 10, 2017

Contributor

In the future we might want to switch to boost::intrusive_ptr<CephContext>.

This comment has been minimized.

@cbodley

cbodley May 17, 2017

Contributor

why not now? it should be a drop-in replacement here

@rzarzynski

This comment has been minimized.

Contributor

rzarzynski commented Jun 23, 2017

jenkins retest this please

@cbodley cbodley added the needs-qa label Jun 23, 2017

@rzarzynski

This comment has been minimized.

Contributor

rzarzynski commented Jun 29, 2017

jenkins retest this please

@yuriw

This comment has been minimized.

@cbodley

This comment has been minimized.

Contributor

cbodley commented Jul 24, 2017

jenkins test this please

@cbodley

This comment has been minimized.

Contributor

cbodley commented Jul 25, 2017

@rzarzynski may need a rebase for the src/test/cli/crushtool/build.t failure

@rzarzynski

This comment has been minimized.

Contributor

rzarzynski commented Jul 25, 2017

Rebasing.

rzarzynski added some commits Jun 23, 2017

common: dout can work also with non-raw pointers to CephContext.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
rgw: fix segfault in RevokeThread during its shutdown procedure.
Fixes: http://tracker.ceph.com/issues/19831
Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
@rzarzynski

This comment has been minimized.

Contributor

rzarzynski commented Jul 26, 2017

jenkins retest this please (run-cli-tests (Failed))

@cbodley cbodley merged commit 1de6bc2 into ceph:master Jul 26, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment