rgw: fix segfault in RevokeThread during its shutdown procedure. #15033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzarzynski
commented
May 10, 2017
| @@ -224,7 +224,7 @@ class TokenCache { | |||
| friend class TokenCache; | |||
| typedef RGWPostHTTPData RGWGetRevokedTokens; | |||
|
|
|||
| CephContext * const cct; | |||
| CephContext* const cct; | |||
There was a problem hiding this comment.
In the future we might want to switch to boost::intrusive_ptr<CephContext>.
There was a problem hiding this comment.
why not now? it should be a drop-in replacement here
cbodley
approved these changes
May 10, 2017
rzarzynski
force-pushed
the
wip-rgw-19831
branch
from
5743922
to
000eb24
Compare
|
jenkins retest this please |
|
jenkins retest this please |
|
jenkins test this please |
|
@rzarzynski may need a rebase for the |
|
Rebasing. |
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Fixes: http://tracker.ceph.com/issues/19831 Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com> Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
rzarzynski
force-pushed
the
wip-rgw-19831
branch
from
000eb24
to
d8606b1
Compare
|
jenkins retest this please ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/19831
Signed-off-by: Radoslaw Zarzynski rzarzynski@mirantis.com