blkin: librbd trace hooks #15053
blkin: librbd trace hooks #15053
Conversation
dillaman
force-pushed
the
wip-librbd-blkin
branch
2 times, most recently
from
fe83b72
to
89197f0
Compare
|
|
|
looks cool, but why does this pr have the cephfs label? |
|
@jcsp Since it touches the dreaded ObjectCacher -- it needs a run through the cephfs test suite to make sure the CephFS client isn't broken. |
|
Ah, okey dokey. |
There was a problem hiding this comment.
lgtm (from rbd point of view). It passed rbd suite tests (c_api, python, fsx).
Also I have run it through fs suite, and it looks good [1].
[1] http://pulpito.ceph.com/trociny-2017-05-16_18:31:32-fs-wip-mgolub-testing---basic-smithi/
|
+1 no issues attributable to this on my fs suite either. |
|
Fixed a conflict due to the redundant header removal in master. |
src/common/zipkin_trace.h
Outdated
| @@ -3,8 +3,6 @@ | |||
| #ifndef COMMON_ZIPKIN_TRACE_H | |||
| #define COMMON_ZIPKIN_TRACE_H | |||
|
|
|||
| #include <string> | |||
| #include "include/encoding.h" | |||
There was a problem hiding this comment.
This was needed to avoid a compile error since ::encode and ::decode are used in this header w/o the declarations
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Victor Araujo <ve.ar91@gmail.com> Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
To collect blkin traced for RBD, set the "rbd blkin trace all" configuration parameter to true. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
dillaman
force-pushed
the
wip-librbd-blkin
branch
from
85e1e8d
to
d939559
Compare
No description provided.