New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blkin: librbd trace hooks #15053

Merged
merged 9 commits into from May 19, 2017

Conversation

Projects
None yet
7 participants
@dillaman
Contributor

dillaman commented May 11, 2017

No description provided.

@dillaman dillaman changed the title from [DNM] blkin: librbd trace hooks to blkin: librbd trace hooks May 13, 2017

@dillaman

This comment has been minimized.

Contributor

dillaman commented May 13, 2017

image

@jcsp

This comment has been minimized.

Contributor

jcsp commented May 15, 2017

looks cool, but why does this pr have the cephfs label?

@dillaman

This comment has been minimized.

Contributor

dillaman commented May 15, 2017

@jcsp Since it touches the dreaded ObjectCacher -- it needs a run through the cephfs test suite to make sure the CephFS client isn't broken.

@jcsp

This comment has been minimized.

Contributor

jcsp commented May 15, 2017

Ah, okey dokey.

@jdurgin

looks great!

@trociny

lgtm (from rbd point of view). It passed rbd suite tests (c_api, python, fsx).

Also I have run it through fs suite, and it looks good [1].

[1] http://pulpito.ceph.com/trociny-2017-05-16_18:31:32-fs-wip-mgolub-testing---basic-smithi/

@jcsp

This comment has been minimized.

Contributor

jcsp commented May 17, 2017

+1 no issues attributable to this on my fs suite either.

@badone badone removed the needs-qa label May 18, 2017

@badone

This comment has been minimized.

Contributor

badone commented May 18, 2017

Fixed a conflict due to the redundant header removal in master.

@@ -3,8 +3,6 @@
#ifndef COMMON_ZIPKIN_TRACE_H
#define COMMON_ZIPKIN_TRACE_H
#include <string>
#include "include/encoding.h"

This comment has been minimized.

@dillaman

dillaman May 18, 2017

Contributor

This was needed to avoid a compile error since ::encode and ::decode are used in this header w/o the declarations

dillaman and others added some commits May 11, 2017

test/librados_test_stub: add new aio_operate overloads for tracing
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
blkin: pass trace information to object cacher
Signed-off-by: Victor Araujo <ve.ar91@gmail.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
blkin: add config variable rbd_blkin_trace_all
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
blkin: improve trace visibility into object cacher
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
common/zipkin_trace: added missing include for encoding
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
blkin: librados should start new child trace
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
blkin: improved objecter trace events
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
blkin: initial trace hooks for IO path
To collect blkin traced for RBD, set the "rbd blkin trace all"
configuration parameter to true.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
blkin: rbd object map update traces
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

@dillaman dillaman merged commit 1eef465 into ceph:master May 19, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@dillaman dillaman deleted the dillaman:wip-librbd-blkin branch May 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment