rgw-multisite: fix the problem of rgw website configure request not redirect to metadata master #15082
Conversation
src/rgw/rgw_op.cc
Outdated
| if (!store->is_meta_master()) { | ||
| op_ret = forward_request_to_master(s, NULL, store, in_data, nullptr); | ||
| if (op_ret < 0) { | ||
| ldout(s->cct, 20) << __func__ << "forward_request_to_master returned ret=" << op_ret << dendl; |
There was a problem hiding this comment.
add a space before forward_request_to_master.
joke-lee
changed the title
|
@tchaikov How about progress about this review ? |
|
@joke-lee i am not familiar with this area. so you might need to ping experts in rgw to get your PR reviewed. i'd recommend you "@" them in the comments in this PR to get their attention. |
|
@cbodley hi, can you help to review this? |
|
@yehudasa hi, can you help to review this? |
|
@liewegas hi, can you help to review this? |
|
@cbodley add test case test_set_bucket_website done, do you mind to review it ? |
|
@joke-lee thanks for adding the test. i didn't realize that this depended on - bucket.set_website_configuration(website_cfg)
+ try:
+ bucket.set_website_configuration(website_cfg)
+ except boto.exception.S3ResponseError as e:
+ if e.error_code == 'MethodNotAllowed':
+ raise SkipTest("test_set_bucket_website skipped. Requires rgw_enable_static_website = 1.")
+ raise
assert(bucket.get_website_configuration_with_xml()[1] == website_cfg.to_xml()) |
…edirect to metadata master Signed-off-by: yuliyang <yuliyang@cmss.chinamobile.com>
|
hi @cbodley ，i have update test case in src/test/rgw/rgw_multi/tests.py ，do you mind to help review it？ |
|
retest this please. |
hi, when i make website configure request to slave zone rgw， and get website configure from master zone,but i can not get the website configure from master zone, and this pull fix the problem.
Signed-off-by: yuliyang yuliyang@cmss.chinamobile.com