Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph: simplify CInode::maybe_export_pin() #15106

Merged
merged 2 commits into from
May 24, 2017

Commits on May 16, 2017

  1. ceph: simplify CInode::maybe_export_pin()

    move most works into MDBalancer::handle_export_pins(), this simplifies
    the code a lot.
    
    Another reason for this change is that creating aux subtree directly in
    CInode::maybe_export_pin() confuses journal replay (the subtree map check
    when replaying ESubtreeMap).
    
    Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
    ukernel committed May 16, 2017
    Configuration menu
    Copy the full SHA
    9d2d032 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2017

  1. mds: don't pin inodes in MDCache::export_pin_queue

    pinning inode can trigger assertion when replaying log
    
     1: (()+0x560ceb) [0x55b263ff7ceb]
     2: (()+0x115c0) [0x7fc0393a75c0]
     3: (gsignal()+0x9f) [0x7fc03812f91f]
     4: (abort()+0x16a) [0x7fc03813151a]
     5: (ceph::__ceph_assert_fail(char const*, char const*, int, char const*)+0x2bc) [0x55b26404158c]
     6: (MDCache::remove_inode(CInode*)+0x316) [0x55b263d9c616]
     7: (MDCache::trim_non_auth_subtree(CDir*)+0x4d8) [0x55b263d9cd68]
     8: (MDCache::try_trim_non_auth_subtree(CDir*)+0x5e2) [0x55b263da7292]
     9: (EExport::replay(MDSRank*)+0x549) [0x55b263fdc619]
     10: (MDLog::_replay_thread()+0xd0f) [0x55b263f8580f]
     11: (MDLog::ReplayThread::entry()+0xd) [0x55b263cebbfd]
     12: (()+0x76ca) [0x7fc03939d6ca]
     13: (clone()+0x5f) [0x7fc038201f7f]
    
    Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
    ukernel committed May 17, 2017
    Configuration menu
    Copy the full SHA
    4d66902 View commit details
    Browse the repository at this point in the history