librbd: reduce potential of erroneous blacklisting on image close #15162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trociny
reviewed
May 19, 2017
|
|
||
| if (m_refreshed_locker != m_locker || m_refreshed_locker == Locker{}) { | ||
| ldout(m_cct, 5) << "no longer lock owner" << dendl; | ||
| finish(-EAGAIN); |
There was a problem hiding this comment.
@dillaman If get_locker returns -ENOENT, BreakRequest returns with -EAGAIN, and acquire_request will fail with -EAGAIN too though it could succeed.
Note, if break_lock returns -ENOENT below, we return success.
There was a problem hiding this comment.
Good point -- I'll push an update in a few
added 2 commits
May 19, 2017 08:43
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
trociny
approved these changes
May 19, 2017
src/librbd/image/CloseRequest.cc
Outdated
| CephContext *cct = m_image_ctx->cct; | ||
| ldout(cct, 10) << this << " " << __func__ << dendl; | ||
|
|
||
| // prevent incoming requests from our peers |
There was a problem hiding this comment.
@dillaman This comment looks like not needed here?
The watch should be released after exclusive lock is released to avoid a potential race condition which would result in the client being blacklisted by a peer. Fixes: http://tracker.ceph.com/issues/19970 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.