rgw: fix radosgw-admin retcode #15257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should check RGWBucketAdminOp::info retcode Signed-off-by: Shasha Lu <lu.shasha@eisoo.com>
cbodley
reviewed
May 24, 2017
src/rgw/rgw_admin.cc
Outdated
| @@ -4491,7 +4491,8 @@ int main(int argc, const char **argv) | |||
| case OPT_USER_RM: | |||
| ret = user.remove(user_op, &err_msg); | |||
| if (ret == -ENOENT) { | |||
| cerr << err_msg << std::endl; | |||
| cerr << "could not remove user: " << err_msg << std::endl; | |||
| return -ret; | |||
There was a problem hiding this comment.
can we just remove the special case for -ENOENT here, and let if (ret < 0) handle this below?
There was a problem hiding this comment.
thanks , already removed.
shashalu
force-pushed
the
fix-rgw-admin-retcode
branch
from
258b33f
to
0e43d2f
Compare
when user.remove got negative retcode should return Signed-off-by: Shasha Lu <lu.shasha@eisoo.com>
shashalu
force-pushed
the
fix-rgw-admin-retcode
branch
from
0e43d2f
to
6b57439
Compare
|
ping @cbodley |
cbodley
approved these changes
May 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix "radosgw-admin user rm" and "radosgw-admin bucket stats" retcode
Signed-off-by: Shasha Lu lu.shasha@eisoo.com