New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: fix radosgw-admin retcode #15257

Merged
merged 2 commits into from Jun 8, 2017

Conversation

Projects
None yet
2 participants
@shashalu
Contributor

shashalu commented May 24, 2017

fix "radosgw-admin user rm" and "radosgw-admin bucket stats" retcode

Signed-off-by: Shasha Lu lu.shasha@eisoo.com

rgw: fix radosgw-admin bucket_stats retcode
should check RGWBucketAdminOp::info retcode

Signed-off-by: Shasha Lu <lu.shasha@eisoo.com>
@@ -4491,7 +4491,8 @@ int main(int argc, const char **argv)
case OPT_USER_RM:
ret = user.remove(user_op, &err_msg);
if (ret == -ENOENT) {
cerr << err_msg << std::endl;
cerr << "could not remove user: " << err_msg << std::endl;
return -ret;

This comment has been minimized.

@cbodley

cbodley May 24, 2017

Contributor

can we just remove the special case for -ENOENT here, and let if (ret < 0) handle this below?

This comment has been minimized.

@shashalu

shashalu May 25, 2017

Contributor

thanks , already removed.

@cbodley cbodley added the rgw label May 24, 2017

rgw: fix "radosgw-admin user rm" retcode
when user.remove got negative retcode should return

Signed-off-by: Shasha Lu <lu.shasha@eisoo.com>
@shashalu

This comment has been minimized.

Contributor

shashalu commented May 31, 2017

ping @cbodley

@cbodley

looks good, i'll include this in my next teuthology run

@cbodley

This comment has been minimized.

@cbodley cbodley merged commit 734083b into ceph:master Jun 8, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment