New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: the condition of last epoch <= superblock.newest_map epoch has been check twice #15590

Merged
merged 1 commit into from Jun 13, 2017

Conversation

Projects
None yet
3 participants
@Linbing

Linbing commented Jun 9, 2017

we have checked condition of last epoch <= superblock.newest_map epoch before we puts diff osdmap to transaction, so , it's unnecessary to check it again after that. last and superblock.newest_map does not be changed during that time.

Signed-off-by: linbing linbing@t2cloud.net

linbing
osd: the condition of last epoch <= superblock.newest_map epoch has been
check before we puts diff osdmap to transaction, it's unnecessary to
check it again after that. last and superblock.newest_map does not
be changed during that time.

Signed-off-by: linbing <linbing@t2cloud.net>
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jun 9, 2017

retest this please.

@tchaikov tchaikov added the needs-qa label Jun 9, 2017

@yuriw

This comment has been minimized.

Contributor

yuriw commented Jun 9, 2017

test this please

@Linbing

This comment has been minimized.

Linbing commented Jun 12, 2017

@ceph-jenkins retest this please

@Linbing

This comment has been minimized.

Linbing commented Jun 12, 2017

@ceph-jenkins retest this please

@yuriw yuriw merged commit b37c4a2 into ceph:master Jun 13, 2017

4 of 5 checks passed

default Build started sha1 is merged.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment