rgw: fix rgw bucket policy IfExists position #15607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tchaikov @cbodley @adamemerson do you mind taking a look, thanks |
|
ok to test |
|
test this please |
Signed-off-by: yuliyang <yuliyang@cmss.chinamobile.com>
adamemerson
approved these changes
Jun 12, 2017
There was a problem hiding this comment.
Lanyards Give Tokens Mystique
Please write a cleaned up test case for this and submit it to s3-tests. Probably base it off @pritha-srivastava 's current PR so it can go in right after.
|
#add s3-test case ceph/s3-tests#167 |
adamemerson
added a commit
that referenced
this pull request
Jun 14, 2017
rgw: fix rgw bucket policy IfExists position Reviewed By: Adam C. Emerson <aemerson@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as http://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_elements.html metioned
IfExists to the end of any condition operator,not to Condition Keys
fix http://tracker.ceph.com/issues/20248
Signed-off-by: yuliyang yuliyang@cmss.chinamobile.com