New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: delete unused config opts of mon_sync_fs_threshold #15676

Merged
merged 1 commit into from Jun 20, 2017

Conversation

Projects
None yet
5 participants
@Linbing

Linbing commented Jun 14, 2017

When arrange my config, I found mon_sync_fs_threshold is not used since hammer, so i suggest to delete it in config_opts

Signed-off-by: linbing linbing@t2cloud.net

@ceph-jenkins

This comment has been minimized.

Collaborator

ceph-jenkins commented Jun 14, 2017

Can one of the admins verify this patch?

@xiexingguo

lgtm

@xiexingguo xiexingguo added the cleanup label Jun 14, 2017

@@ -264,7 +264,6 @@ OPTION(inject_early_sigterm, OPT_BOOL, false)
OPTION(mon_data, OPT_STR, "/var/lib/ceph/mon/$cluster-$id")
OPTION(mon_initial_members, OPT_STR, "") // list of initial cluster mon ids; if specified, need majority to form initial quorum and create new cluster
OPTION(mon_sync_fs_threshold, OPT_INT, 5) // sync() when writing this many objects; 0 to disable.

This comment has been minimized.

@tchaikov

tchaikov Jun 14, 2017

Contributor

could you please update doc/rados/configuration/mon-config-ref.rst accordingly?

This comment has been minimized.

@Linbing

Linbing Jun 14, 2017

I forget this, Thank you.

@tchaikov tchaikov added the common label Jun 14, 2017

@@ -1025,12 +1025,6 @@ Miscellaneous
:Type: 32-bit Integer
:Default: ``100``
``mon sync fs threshold``

This comment has been minimized.

@tchaikov

tchaikov Jun 14, 2017

Contributor

the prefix of the title of this commit should be "doc: ", not "mon: ".

@Linbing Linbing changed the title from mon: delete unused config opts of mon_sync_fs_threshold to doc: delete unused config opts of mon_sync_fs_threshold Jun 14, 2017

@Linbing Linbing changed the title from doc: delete unused config opts of mon_sync_fs_threshold to mon: delete unused config opts of mon_sync_fs_threshold Jun 14, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jun 14, 2017

could you remove the merge commit, and squash these commits into a single one or two if you feel necessary?

linbing
mon: delete unused config opts of mon_sync_fs_threshold and remove it…
… in mon-config-ref

Signed-off-by: linbing <linbing@t2cloud.net>

@liewegas liewegas added needs-qa and removed needs-qa labels Jun 20, 2017

@liewegas liewegas merged commit 6743fb2 into ceph:master Jun 20, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment