mon: delete unused config opts of mon_sync_fs_threshold #15676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
tchaikov
reviewed
Jun 14, 2017
| @@ -264,7 +264,6 @@ OPTION(inject_early_sigterm, OPT_BOOL, false) | |||
|
|
|||
| OPTION(mon_data, OPT_STR, "/var/lib/ceph/mon/$cluster-$id") | |||
| OPTION(mon_initial_members, OPT_STR, "") // list of initial cluster mon ids; if specified, need majority to form initial quorum and create new cluster | |||
| OPTION(mon_sync_fs_threshold, OPT_INT, 5) // sync() when writing this many objects; 0 to disable. | |||
There was a problem hiding this comment.
could you please update doc/rados/configuration/mon-config-ref.rst accordingly?
tchaikov
reviewed
Jun 14, 2017
| @@ -1025,12 +1025,6 @@ Miscellaneous | |||
| :Type: 32-bit Integer | |||
| :Default: ``100`` | |||
|
|
|||
| ``mon sync fs threshold`` | |||
There was a problem hiding this comment.
the prefix of the title of this commit should be "doc: ", not "mon: ".
Linbing
changed the title
Linbing
changed the title
|
could you remove the merge commit, and squash these commits into a single one or two if you feel necessary? |
… in mon-config-ref Signed-off-by: linbing <linbing@t2cloud.net>
Linbing
force-pushed
the
wip-mon-delete-unused-config
branch
from
1df5df3
to
7fc7825
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When arrange my config, I found mon_sync_fs_threshold is not used since hammer, so i suggest to delete it in config_opts
Signed-off-by: linbing linbing@t2cloud.net