New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libradosstriper silently fails to delete empty objects in jewel #15760

Merged
merged 1 commit into from Aug 28, 2017

Conversation

Projects
None yet
3 participants
@smithfarm
Contributor

smithfarm commented Jun 19, 2017

libradosstriper: delete striped objects of zero length
This patch fixes the bug: "libradosstriper fails to delete striped objects of
zero length without returning any kind of error"

N.B.: This is not cherry picked from master because
7a50ea4, which fixes the issue in master, is
too complicated to backport.

Fixes: http://tracker.ceph.com/issues/20325
Signed-off-by: Stan K <redrampage@selectel.ru>

@smithfarm smithfarm self-assigned this Jun 19, 2017

@smithfarm smithfarm added this to the jewel milestone Jun 19, 2017

@smithfarm smithfarm requested a review from jdurgin Jun 19, 2017

@liewegas

This comment has been minimized.

Show comment
Hide comment
@liewegas

liewegas Jun 20, 2017

Member

Is there a set of striper tests that can cover this?

Member

liewegas commented Jun 20, 2017

Is there a set of striper tests that can cover this?

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Jul 12, 2017

Contributor

@liewegas Apparently not. Should the absence of tests be considered a blocker?

Contributor

smithfarm commented Jul 12, 2017

@liewegas Apparently not. Should the absence of tests be considered a blocker?

@liewegas

This comment has been minimized.

Show comment
Hide comment
@liewegas

liewegas Jul 12, 2017

Member

Probably not, since we already lack sufficient tests for striper. (FWIW this is why downstream RHCS removes it.)

Member

liewegas commented Jul 12, 2017

Probably not, since we already lack sufficient tests for striper. (FWIW this is why downstream RHCS removes it.)

@jdurgin

This comment has been minimized.

Show comment
Hide comment
@jdurgin

jdurgin Jul 13, 2017

Member

there are basic tests - ceph_test_rados_striper_api_[a]io (from src/test/libradosstriper) - but this fix is obvious enough that I don't think they're a blocker

Member

jdurgin commented Jul 13, 2017

there are basic tests - ceph_test_rados_striper_api_[a]io (from src/test/libradosstriper) - but this fix is obvious enough that I don't think they're a blocker

@smithfarm

This comment has been minimized.

Show comment
Hide comment
Contributor

smithfarm commented Aug 28, 2017

@smithfarm smithfarm merged commit cccacd7 into ceph:jewel Aug 28, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-20325-jewel branch Aug 28, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Aug 29, 2017

Contributor

This passed the following relevant suites:

Contributor

smithfarm commented Aug 29, 2017

This passed the following relevant suites:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment