libradosstriper silently fails to delete empty objects in jewel #15760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the bug: "libradosstriper fails to delete striped objects of zero length without returning any kind of error" N.B.: This is not cherry picked from master because 7a50ea4, which fixes the issue in master, is too complicated to backport. Fixes: http://tracker.ceph.com/issues/20325 Signed-off-by: Stan K <redrampage@selectel.ru>
|
Is there a set of striper tests that can cover this? |
|
@liewegas Apparently not. Should the absence of tests be considered a blocker? |
|
Probably not, since we already lack sufficient tests for striper. (FWIW this is why downstream RHCS removes it.) |
jdurgin
approved these changes
Jul 13, 2017
|
there are basic tests - ceph_test_rados_striper_api_[a]io (from src/test/libradosstriper) - but this fix is obvious enough that I don't think they're a blocker |
|
http://pulpito.ceph.com:80/smithfarm-2017-08-27_18:29:25-rados-wip-jewel-backports-distro-basic-smithi/ (failures appear unrelated) |
|
This passed the following relevant suites:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/20325