New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: fix hang on deprecated/removed 'pg set_*full_ratio' commands #16300

Merged
merged 2 commits into from Jul 14, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Member

liewegas commented Jul 12, 2017

mon/MonCommands: mark 'pg set_*_ratio' deprecated
Signed-off-by: Sage Weil <sage@redhat.com>
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 13, 2017

retest this please.

@liewegas liewegas requested a review from gregsfortytwo Jul 13, 2017

@liewegas liewegas added this to the luminous milestone Jul 13, 2017

mon->reply_command(op, -EOPNOTSUPP, "this command is obsolete", rdata,
get_last_committed());
return false;
}

This comment has been minimized.

@gregsfortytwo

gregsfortytwo Jul 13, 2017

Member

Shouldn't these return true, as they've been handled?

This comment has been minimized.

@liewegas

liewegas Jul 13, 2017

Member

yep, updated!

mon/PGMonitor: EOPNOTSUPP for old pgmon commands
This includes 'pg set_full_ratio', which we have only for the upgrade, but
goes away afterwards.

Also, return true to either swallow the request or indicate it has been
processed.

Fixes: http://tracker.ceph.com/issues/20600
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas merged commit 7e287a4 into ceph:master Jul 14, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@liewegas liewegas deleted the liewegas:wip-20600 branch Jul 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment