cephfs/fuse: set big_writes default is false #16562
Conversation
|
I don't think we want to remove an option which may still be useful on platforms with an older fuse? They only removed that option last December. |
src/common/legacy_config_opts.h
Outdated
| @@ -410,7 +410,6 @@ OPTION(fuse_use_invalidate_cb, OPT_BOOL, true) // use fuse 2.8+ invalidate callb | |||
| OPTION(fuse_disable_pagecache, OPT_BOOL, false) | |||
| OPTION(fuse_allow_other, OPT_BOOL, true) | |||
| OPTION(fuse_default_permissions, OPT_BOOL, false) | |||
| OPTION(fuse_big_writes, OPT_BOOL, true) | |||
There was a problem hiding this comment.
You must also change options.cc and remove the same entry.
There was a problem hiding this comment.
@batrick updated it
renhwztetecs
force-pushed
the
renhw-wip-fuse-mount
branch
2 times, most recently
from
f1a594c
to
a1196fd
Compare
|
I think I'd prefer that we just change the default to false for the config option. Add a comment explaining that big_writes is deprecated in libfuse 3.0.0. |
renhwztetecs
force-pushed
the
renhw-wip-fuse-mount
branch
from
a1196fd
to
6ce96c7
Compare
renhwztetecs
changed the title
|
good idea! I changed it thanks |
Please make a Ceph tracker ticket for this along with an explanation for what |
|
@batrick |
* refs/remotes/upstream/pull/16562/head: cephfs/fuse: set big_writes default is false Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
|
Deferring this until after Luminous. |
The -o big_writes mount option has been removed in the libfuse 3.0 because it is now always active. see: https://github.com/libfuse/libfuse/blob/master/ChangeLog.rst so we big_writes default is false Signed-off-by: huanwen ren <ren.huanwen@zte.com.cn>
renhwztetecs
force-pushed
the
renhw-wip-fuse-mount
branch
from
f40db34
to
98b9828
Compare
|
jenkins retest this please |
* refs/remotes/upstream/pull/16562/head: cephfs/fuse: set big_writes default is false Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
The -o big_writes mount option has been removed in the libfuse 3.0
because it is now always active.
see: https://github.com/libfuse/libfuse/blob/master/ChangeLog.rst
so we big_writes default is false
Signed-off-by: huanwen ren ren.huanwen@zte.com.cn