rbd: switched from legacy to new-style configuration options #16737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will move documentation over to schema once PR #16735 merges |
dillaman
force-pushed
the
wip-rbd-config
branch
from
2d995d0
to
c131722
Compare
dillaman
changed the title
trociny
reviewed
Aug 8, 2017
| @@ -164,7 +164,6 @@ TEST_F(TestJournalEntries, AioDiscard) { | |||
| REQUIRE_FEATURE(RBD_FEATURE_JOURNALING); | |||
|
|
|||
| CephContext* cct = reinterpret_cast<CephContext*>(_rados.cct()); | |||
| REQUIRE(!cct->_conf->rbd_skip_partial_discard); | |||
There was a problem hiding this comment.
@dillaman cct variable is unused now. But I think we still need to skip the test when partial discard is enabled, due to journal events are optimized out for empty objects. See our discussion here: #10060 (comment)
% CEPH_ARGS='--rbd_skip_partial_discard=true' RBD_FEATURES=109 CEPH_LIB=./lib ./bin/unittest_librbd --gtest_filter=TestJournalEntries.AioDiscard
Note: Google Test filter = TestJournalEntries.AioDiscard
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from TestJournalEntries
[ RUN ] TestJournalEntries.AioDiscard
/home/mgolub/ceph.ci/src/test/librbd/journal/test_Entries.cc:181: Failure
Value of: wait_for_entries_available(ictx)
Actual: false
Expected: true
[ FAILED ] TestJournalEntries.AioDiscard (10018 ms)
[----------] 1 test from TestJournalEntries (10018 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (10047 ms total)
[ PASSED ] 0 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] TestJournalEntries.AioDiscard
1 FAILED TEST
c131722
to
dd55d1f
Compare
|
@trociny update pushed |
|
@dillaman It needs update after #15579 merge. |
smithfarm
reviewed
Aug 9, 2017
|
please link with tracker if appropriate |
Fixes: http://tracker.ceph.com/issues/20737 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
dillaman
force-pushed
the
wip-rbd-config
branch
from
dd55d1f
to
7dc82bc
Compare
|
rebase pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jason Dillaman dillaman@redhat.com