common/LogClient: assign seq and queue atomically #16828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test this please |
gregsfortytwo
dismissed
their stale review
We should make last_log a non-atomic
gregsfortytwo
requested changes
Aug 4, 2017
|
jenkins test this please |
|
retest this please |
|
retest this please |
The _get_mon_log_message() assumes that log_last and log_queue are in sync, but it was previously possible to increment log_last setting e.seq in do_log(), and only later queue it. If a racing thread ran get_mon_log_message() in the meantime it would fail an assertion. Fix by assigning the seq and queueing it atomically. If the cluster log is not enabled, use the get_next_seq() helper so that graylog or syslog messages still have a seq assigned. Fixes: http://tracker.ceph.com/issues/18209 Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/18209