Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg/async/rdma: fix the bug that rdma polling thread uses the same thread name with msg worker #16936

Merged
merged 2 commits into from
Aug 11, 2017

Conversation

TsaiJin
Copy link
Contributor

@TsaiJin TsaiJin commented Aug 9, 2017

Before this PR, the rdma polling thread doesn't has its own thread name and inherits the thread name(msgr-worker-x) of its parent thread.
So that we can see that a ceph-osd deamon will have two threads with the same name, and it is extremely confusing:

#ps H  -p 23454 -o 'pid tid comm'  | grep msgr-worker
23454 23456 msgr-worker-0
23454 23457 msgr-worker-1
23454 23458 msgr-worker-2
23454 23494 msgr-worker-0

@TsaiJin TsaiJin force-pushed the wip-set-polling-thread-name branch 2 times, most recently from 4be0e7a to f65ccaf Compare August 9, 2017 08:50
…sg worker

Signed-off-by: Jin Cai <caijin.caij@alibaba-inc.com>
@TsaiJin TsaiJin force-pushed the wip-set-polling-thread-name branch from f65ccaf to 9a1e1af Compare August 9, 2017 11:50
@TsaiJin TsaiJin changed the title msg/async/rdma/RDMAStack: set a unique name for the rdma polling thread msg/async/rdma/RDMAStack: fix the bug that rdma polling thread uses the same thread name with msg worker Aug 9, 2017
@TsaiJin TsaiJin changed the title msg/async/rdma/RDMAStack: fix the bug that rdma polling thread uses the same thread name with msg worker msg/async/rdma: fix the bug that rdma polling thread uses the same thread name with msg worker Aug 9, 2017
@TsaiJin
Copy link
Contributor Author

TsaiJin commented Aug 9, 2017

retest this please.

@TsaiJin
Copy link
Contributor Author

TsaiJin commented Aug 9, 2017

@yuyuyu101 @joscollin please help take a look.

@joscollin
Copy link
Member

@TsaiJin When I get a chance to look at this PR, it is already approved :-)

@yuriw yuriw merged commit 4663497 into ceph:master Aug 11, 2017
@TsaiJin TsaiJin deleted the wip-set-polling-thread-name branch August 14, 2017 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants