rgw: Drop #warning TODO

[joscollin]

Drop "#warning TODO" from rgw_crypt.cc, as the tracker is created for this requirement and the
corresponding PR is in progress for a long time.

Tracker: http://tracker.ceph.com/issues/19851
PR: #14498

The below warning is displayed during build:

ceph/src/rgw/rgw_crypt.cc:38:2: warning: #warning "TODO: move this code to auth/Crypto for others to reuse." [-Wcpp]
 #warning "TODO: move this code to auth/Crypto for others to reuse."
  ^
ceph/src/rgw/rgw_crypt.cc:247:2: warning: #warning "TODO: use auth/Crypto instead of reimplementing." [-Wcpp]
 #warning "TODO: use auth/Crypto instead of reimplementing."
  ^

Signed-off-by: Jos Collin jcollin@redhat.com

[amitkumar50]

warnings were added to move the code to auth/Cryto.
But Have you raised an PR for movement?
Or any existing PR that has done movement.
I believe class AES_256_CTR needed to be moved .. but not done yet

[joscollin]

@amitkumar50 Please read the PR description above for the PR details for the movement.

First of all, adding warnings like this is not a good practise and the TODO should be specified in a tracker. Not within the code itself.

This PR is created as the PR #14498 takes too long to get merged.

[joscollin]

@amitkumar50
In addition to my previous comment, it is ridiculous to purposefully create warnings for the TODO comments in the code.

[yehudasa]

maybe @aclamk remembers why the #warnings, I vaguely remember it might have been @liewegas that asked to do it. Anyhow, it'd be better to revert 326a16d.

[joscollin]

@yehudasa Yeah, that may be true. But it's been annoying nowadays as it appears in every other PR builds.

[theanalyst]

@joscollin the advantage if you revert the commit is we have the warning retained as comment and helps us trace back git histories better

[gregsfortytwo]

We already have a ticket for doing the work, and this warning needs to go away — it's occasionally hiding real warnings from people.

Reviewed-by: Greg Farnum gfarnum@redhat.com