Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgw: Drop #warning TODO #17012

Merged
merged 1 commit into from
Aug 15, 2017
Merged

rgw: Drop #warning TODO #17012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/rgw/rgw_crypt.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ using namespace rgw;
/**
* Encryption in CTR mode. offset is used as IV for each block.
*/
#warning "TODO: move this code to auth/Crypto for others to reuse."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warnings were added to move the code to auth/Cryto.
But Have you raised an PR for movement?
Or any existing PR that has done movement.
I believe class AES_256_CTR needed to be moved .. but not done yet

Copy link
Member Author

@joscollin joscollin Aug 14, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amitkumar50 Please read the PR description above for the PR details for the movement.

First of all, adding warnings like this is not a good practise and the TODO should be specified in a tracker. Not within the code itself.

This PR is created as the PR #14498 takes too long to get merged.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amitkumar50
In addition to my previous comment, it is ridiculous to purposefully create warnings for the TODO comments in the code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe @aclamk remembers why the #warnings, I vaguely remember it might have been @liewegas that asked to do it. Anyhow, it'd be better to revert 326a16d.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yehudasa Yeah, that may be true. But it's been annoying nowadays as it appears in every other PR builds.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joscollin the advantage if you revert the commit is we have the warning retained as comment and helps us trace back git histories better


class AES_256_CTR : public BlockCrypt {
public:
static const size_t AES_256_KEYSIZE = 256 / 8;
Expand Down Expand Up @@ -244,7 +242,6 @@ CryptoAccelRef get_crypto_accel(CephContext *cct)
* 6. (Special case) If m == 0 then last n bytes are xor-ed with pattern
* obtained by CBC ENCRYPTION of {0} with IV derived from offset
*/
#warning "TODO: use auth/Crypto instead of reimplementing."
class AES_256_CBC : public BlockCrypt {
public:
static const size_t AES_256_KEYSIZE = 256 / 8;
Expand Down