tests: qa/standalone: Add trap for signals to restore the kernel core pattern #17026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzafman
changed the title
…e pattern Signed-off-by: David Zafman <dzafman@redhat.com>
dzafman
changed the title
dzafman
changed the title
|
retest this please |
tchaikov
reviewed
Aug 18, 2017
| if [ -n "$precore" ]; then | ||
| sudo sysctl -w ${KERNCORE}=${precore} | ||
| fi | ||
| exit 0 |
There was a problem hiding this comment.
no need to exit 0. and might want to reuse this function at https://github.com/ceph/ceph/pull/17026/files#diff-5e483a2d055861968b99eacaa3688b6fR108.
There was a problem hiding this comment.
@tchaikov With daemons running if I don't exit here weird things happened. I don't remember exactly what happened, but I tried it with a common function. I think I had to ^C twice to get the test to stop running.
tchaikov
approved these changes
Aug 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.