New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
submodule: make libmpem as a submodule. #17036
Conversation
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
@@ -58,3 +58,6 @@ | |||
[submodule "src/rapidjson"] | |||
path = src/rapidjson | |||
url = https://github.com/ceph/rapidjson | |||
[submodule "src/nvml"] | |||
path = src/nvml | |||
url = https://github.com/ceph/nvml.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@majianpeng Sorry but "https://github.com/ceph/nvml.git" says "Page not found"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, now it's not exist. I don't know how to fork a submodule . Maybe it need Sage to do this .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liewegas Can you kindly look at this?
@@ -58,3 +58,6 @@ | |||
[submodule "src/rapidjson"] | |||
path = src/rapidjson | |||
url = https://github.com/ceph/rapidjson | |||
[submodule "src/nvml"] | |||
path = src/nvml | |||
url = https://github.com/ceph/nvml.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liewegas Can you kindly look at this?
#15102 already merged into master. But most distro don't include this libpmem. So add nvml as submodule. @liewegas , how to fork nvml as a submodule ? Thanks!