mon/OSDMonitor: do not send_pg_creates with stale info #17065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| << " not using stale creating_pgs@" << creating_pgs_epoch << dendl; | ||
| // the subscribers will be updated when the mapping is completed anyway | ||
| return next; | ||
| } |
There was a problem hiding this comment.
Hmm, we don't send creates on a timer or anything that I can see. Is it really safe to assume we'll get asked to send them again if we just skip it here?
There was a problem hiding this comment.
@gregsfortytwo C_UpdateCreatingPGs calls update_creating_pgs() and check_pg_creates_subs() when it's done with the mapping. so i think, once creating_pgs_by_osd_epoch is sync'ed with creating_pgs.pgs, we will send the pg creates to OSDs.
and we always try to start the mapping when the osdmap is committed, see OSDMonitor::on_active(). so it's safe to assume so, i believe.
|
@tchaikov, should run this through testing before merge? |
|
@gregsfortytwo yes, should run it thru rados qa suite. |
|
we reset the "creating_pgs" with the newly accepted paxos proposal, but the creating_pgs_by_osd_epoch is out-of-sync with the new creating_pgs. so we are at risk of using stale creating_pgs_by_osd_epoch along with the new creating_pgs.pgs. to avoid this racing, we need to check the creating_pgs_epoch before sending pg-creates using creating_pgs_by_osd_epoch. Fixes: http://tracker.ceph.com/issues/20785 Signed-off-by: Kefu Chai <kchai@redhat.com>
|
changelog
|
|
retest this please |
|
jdurgin
approved these changes
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we reset the "creating_pgs" with the newly accepted paxos proposal, but
the creating_pgs_by_osd_epoch is out-of-sync with the new creating_pgs.
so we are at risk of using stale creating_pgs_by_osd_epoch along with
the new creating_pgs.pgs. to avoid this racing, we need to check the
creating_pgs_epoch before sending pg-creates using
creating_pgs_by_osd_epoch.
Fixes: http://tracker.ceph.com/issues/20785
Signed-off-by: Kefu Chai kchai@redhat.com