os/bluestore: compensate for bad freelistmanager size/blocks metadata #17268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This repairs bluestores created before http://tracker.ceph.com/issues/21089 was fixed in f6f1ae3. In both cases, the freelistmanager's size is off by one block (4k). In one case, it is just a matter of fixing the size and twiddling the trailing bit. In the second case, the size delta causes freelistmanager to need a new row, which means the blocks count also changes, and we have lots of bits to zero (all but one in the new row). Both are silently corrected by fsck in this patch. Fixes: http://tracker.ceph.com/issues/21089 Signed-off-by: Sage Weil <sage@redhat.com>
|
backport: #17273 |
|
I think we should actually revert the commit in master, since all upgrades will pass through luminous and the issue will get corrected there. |
yeah, #17275 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repairs bluestores created before http://tracker.ceph.com/issues/21089
was fixed in f6f1ae3.
In both cases, the freelistmanager's size is off by one block (4k). In
one case, it is just a matter of fixing the size and twiddling the trailing
bit. In the second case, the size delta causes freelistmanager to need
a new row, which means the blocks count also changes, and we have lots
of bits to zero (all but one in the new row).
Both are silently corrected by fsck in this patch.
Fixes: http://tracker.ceph.com/issues/21089
Signed-off-by: Sage Weil sage@redhat.com