Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Don't dump core when using EXPECT_DEATH #17390

Merged
merged 1 commit into from
Aug 31, 2017

Conversation

tchaikov
Copy link
Contributor

Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov tchaikov added the tests label Aug 31, 2017
@tchaikov tchaikov requested a review from badone August 31, 2017 08:50
@tchaikov
Copy link
Contributor Author

see also #14821

reported by @kungf

@kungf
Copy link

kungf commented Aug 31, 2017

TEST(OrderedThrottle, destruct) has EXPECT_DEATH may be not cored too.

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
Copy link
Contributor Author

@kungf fixed and repushed

Copy link
Contributor

@badone badone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Kefu

@tchaikov tchaikov merged commit 00b7856 into ceph:master Aug 31, 2017
@tchaikov tchaikov deleted the wip-test-coredump branch August 31, 2017 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants