qa: add cbt task for performance testing #17583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neha Ojha <nojha@redhat.com>
Signed-off-by: Neha Ojha <nojha@redhat.com>
jdurgin
reviewed
Sep 8, 2017
| osd_ra: [4096] | ||
| pool_profile: 'rbd' | ||
| log_avg_msec: 100 | ||
| cmd_path: '/usr/local/bin/fio' |
There was a problem hiding this comment.
the cbt task should probably set this automatically if there's a librbdfio section
jdurgin
reviewed
Sep 8, 2017
qa/tasks/cbt.py
Outdated
| 'cd', os.path.join(testdir, 'fio'), run.Raw('&&'), | ||
| './configure', run.Raw('&&'), | ||
| 'make', run.Raw('&&'), | ||
| 'sudo', 'make', 'install' |
There was a problem hiding this comment.
should avoid 'make install' into a persistent dir, since the machines will get reused, and could get problems from different versions later
configure with --prefix=testdir/fio/build or something, so that it's cleaned up at the end?
jdurgin
reviewed
Sep 8, 2017
| rebuild_every_test=False, | ||
| use_existing=True, | ||
| iterations=self.config.get('cluster', {}).get('iterations', 1), | ||
| tmp_dir='/tmp/cbt', |
There was a problem hiding this comment.
maybe make this in the archive dir, so we save anything that cbt doesn't summarize as well
There was a problem hiding this comment.
As discussed, this change doesn't seem to be required at the moment, because the cbt task archives all the information generated in the cbt results dir.
Signed-off-by: Neha Ojha <nojha@redhat.com>
|
Yay Neha! |
jdurgin
approved these changes
Sep 14, 2017
jdurgin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to run cbt performance tests using teuthology.
We can provide a normal cbt configuration to the cbt task, telling it which benchmarks to run and it will setup performance tests on teuthology nodes.
Signed-off-by: Neha Ojha nojha@redhat.com